1191696 - Have DecodedStream::StartPlayback return a promse to indicate the end of stream playback

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

To be more consistent with AudioSink which also has this change in bug 1185407.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1191696. Part 1 - Handle the promise returned by DecodedStream::StartPlayback in MDSM.

Bug 1191696. Part 1 - Handle the promise returned by DecodedStream::StartPlayback in MDSM.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1191696. Part 2 - implementation in DecodedStream.

Bug 1191696. Part 2 - implementation in DecodedStream.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8647872 [details]
MozReview Request: Bug 1191696. Part 1 - Handle the promise returned by DecodedStream::StartPlayback in MDSM.

https://reviewboard.mozilla.org/r/16067/#review14477

Ship It!

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8647873 [details]
MozReview Request: Bug 1191696. Part 2 - implementation in DecodedStream.

https://reviewboard.mozilla.org/r/16069/#review14479

Ship It!

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6dd75dc65de3
https://hg.mozilla.org/integration/mozilla-inbound/rev/e44c94a159db

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6dd75dc65de3
https://hg.mozilla.org/mozilla-central/rev/e44c94a159db