1191868 - Convert simulator to be based on Mulet

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Simulator, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Mulet is getting good test coverage in automation, and there is interest in having less environments to worry about, like removing b2g-desktop builds.

We should convert the Simulator add-on so that it's based on Mulet instead of b2g-desktop, so we can remove a dependency on b2g-desktop.

We would still offer the same feature set and UI as the existing simulator does today, it's just built around a different base internally.

Comment 1

[Gregor Wagner [:gwagner]]

Is there any progress on this?

Comment 2

[Alexandre Poirot [:ochameau]]

No, we just managed to get simulator working after addon signing story broke all addons...
We will now look into this mulet.
I'll.

Comment 3

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=261b8b0c403c

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: tweak webide to support mulet sim - v1

I haven't found any reasonable way to override the default chrome URI
loaded from Mulet. There is the browser glue component of firefox
that opens a browser.xul window no matter what.
And I don't want to introduce some mulet specifics in this firefox code.
There might be a way to hack this by monkey patching stuff during build
process of the addon, but I found that WebIDE easier to maintain.

The good side of this technique is that it can give control to WebIDE
to open the browser UI of mulet or not.
The bad side of it is that it will make the addon behave very badly
on FF44- or actually, we should ensure that this addon is not compatible with FF44-!

You can test this patch with this try build:
  https://queue.taskcluster.net/v1/task/M8_NIQqCROKYAziPa7kKtg/runs/0/artifacts/public/build/fx-os-simulator-2.5.20150923160039-linux64.xpi

Comment 5

[Alexandre Poirot [:ochameau]]

Comment on attachment 8664977 [details] [diff] [review]
tweak webide to support mulet sim - v1

What do you think about the whole mulet story here?
You can look at the related build script attachment 8664939 [details] [diff] [review].

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: remove b2g-desktop simulator support

Then, if we are happy with simulator builds,
we can cleanup stuff by removing unecessary addon files,
as well as removing b2g desktop support.

I throw the patch here, but that sounds more like a followup.

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8664977 [details] [diff] [review]
tweak webide to support mulet sim - v1

This seems fine to me.  Like you mentioned, we may want to restrict the Mulet based add-on to versions of WebIDE that know about this extra param.

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Alexandre Poirot [:ochameau] from comment #6)
> Created attachment 8665384 [details] [diff] [review]
> remove b2g-desktop simulator support
> 
> Then, if we are happy with simulator builds,
> we can cleanup stuff by removing unecessary addon files,
> as well as removing b2g desktop support.
> 
> I throw the patch here, but that sounds more like a followup.

Yes, let's move this to a follow up.

Comment 9

[Alexandre Poirot [:ochameau]]

Attachment: Bump addon fx minVersion

Comment 10

[Alexandre Poirot [:ochameau]]

Comment on attachment 8664977 [details] [diff] [review]
tweak webide to support mulet sim - v1

Review of attachment 8664977 [details] [diff] [review]:
-----------------------------------------------------------------

We are now able to build simulator addons for linux from try.
I may replace the try build (to prevent building simulators for all try builds)
by building it on mozilla-central revisions so that we get nightlies.

I think we can now proceed with this patch.

I just launched a try run to get a simulator:
  https://treeherder.allizom.org/#/jobs?repo=try&revision=db2f08371226
The build should be available on this page once the build is done:
  https://tools.taskcluster.net/task-graph-inspector/#MFBnNqrETGa_q3-CVN8XWg/H3mwCNx3RMSYcG_hkMawUg

Comment 11

[Alexandre Poirot [:ochameau]]

So the build is available here:
  https://queue.taskcluster.net/v1/task/H3mwCNx3RMSYcG_hkMawUg/runs/0/artifacts/public/build/fxos-simulator-2.5.20151001132505-linux64.xpi

Comment 12

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e2bef59a6295

Comment 13

[Alexandre Poirot [:ochameau]]

https://hg.mozilla.org/integration/fx-team/rev/226ab102869c5fddbd99092c22ffb08fdf93935d
Bug 1191868 - Bump fxos simulator addon compatiblity to current nightly. r=jryans

https://hg.mozilla.org/integration/fx-team/rev/350c0e6a2d5809fadd5a0349b4864c5eb2333a31
Bug 1191868 - Tweak WebIDE to support Simulator based on Mulet. r=jryans

Comment 14

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb2befd38a26

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/226ab102869c
https://hg.mozilla.org/mozilla-central/rev/350c0e6a2d58