1192063 - Z-Order bug when mousing over tab-audio icon

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Vladan Djeric (:vladan)]

Attachment: Screenshot

Comment 1

[(no longer active)]

Attachment: Adjust the z-index of the tab icon overlay to be higher than that of the tab icon

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8644702 [details] [diff] [review]
Adjust the z-index of the tab icon overlay to be higher than that of the tab icon

Review of attachment 8644702 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/tabs.inc.css
@@ +96,5 @@
>    margin-top: -12px;
>    -moz-margin-start: -16px;
>    display: none;
> +  position: relative;
> +  z-index: 4; /* the tab's icon z-index + 1 */

I'm able to fix this bug locally by just setting position:relative; on the .tab-icon-overlay. No z-index is needed on .tab-icon-image or .tab-icon-overlay and no position:relative needed on .tab-icon-image.

Comment 3

[(no longer active)]

You're right!

Comment 4

[(no longer active)]

Attachment: Create a stacking context for the tab overlay icon so that its background paints in front of the tab image

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8644747 [details] [diff] [review]
Create a stacking context for the tab overlay icon so that its background paints in front of the tab image

Review of attachment 8644747 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7409dc9f90d7

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7409dc9f90d7

Comment 8

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using Aurora 42.0a2 (buildID: 20150818004007).