1192311 - upload release files to candidates instead of nightly

Status: VERIFIED FIXED

(Cloud Services :: General, defect)

Description

[[e-mail] (:bhearsum)]

Although we still support candidates dirs in /pub/mozilla.org/firefox/nightly on FTP, /pub/mozilla.org/firefox/candidates is the official location of them. The new post upload script is only uploading to nightly, and returning URLs pointing there as well. Now is a good time to cut over and only support release builds in /pub/mozilla.org/firefox/candidates, so we may as well do it.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Yes please.

Comment 2

[Jeremy Orem [:oremj]]

What change needs to be made?

Comment 3

[[e-mail] (:bhearsum)]

(In reply to Jeremy Orem [:oremj] from comment #2)
> What change needs to be made?

Files should go into /pub/$product/candidates instead of /pub/$product/nightly when --release-to-candidates is used. I think https://github.com/mozilla-services/product-delivery-tools/blob/master/post_upload/postupload/release.go#L150 and https://github.com/mozilla-services/product-delivery-tools/blob/master/post_upload/postupload/release.go#L170 are returning the wrong thing (r.nightlyPath(), in particular)

Comment 4

[Jeremy Orem [:oremj]]

https://github.com/mozilla-services/product-delivery-tools/pull/28 r?

Comment 5

[[e-mail] (:bhearsum)]

(In reply to Jeremy Orem [:oremj] from comment #4)
> https://github.com/mozilla-services/product-delivery-tools/pull/28 r?

Looks good to me. I can veriy once it's deployed.

Comment 6

[Jeremy Orem [:oremj]]

The new version has been deployed.

Comment 7

[[e-mail] (:bhearsum)]

Looks to be working, thanks for the quick fix :)