1192875 - Link to specific revision in dxr from file view in mozilla-central

Status: NEW

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Andrew Halberstadt [:ahal]]

Now that dxr apparently indexes every revision and supports permalinking we should add a link to it from the file view.

E.g, on:
https://hg.mozilla.org/mozilla-central/file/2be4be656c7f/CLOBBER

Add a link to:
https://dxr.mozilla.org/mozilla-central/rev/2be4be656c7f/CLOBBER

A gotcha is that dxr can take awhile to index, so until that happens the links will 404.

Comment 1

[Gregory Szorc [:gps]]

This is a low-hanging fruit. Basically copying the approach we took for Treeherder URLs.

ErikRose: are all mozilla-central revisions available in DXR? Or did you e.g. only start indexing after a specific commit?

Comment 2

[Gregory Szorc [:gps]]

Actually, not super low hanging fruit since Mercurial doesn't provide an obvious place to extend the templates for files. Still doable though.

Comment 3

[Erik Rose [:erik][:erikrose]]

Greg: all the revisions from the beginning of time up until the latest index are available. (Right now, trees that involve a long build process, like moz-central, are built every 6 hours, and others are built more often or are triggered by VCS commits.) We don't actually index each revision--they're not available for searching--but we pull from a local hg checkout in realtime.