Closed
Bug 1193172
Opened 9 years ago
Closed 9 years ago
[Callscreen] Keyboard transitions are broken
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect)
Tracking
(b2g-master verified)
VERIFIED
FIXED
FxOS-S5 (21Aug)
Tracking | Status | |
---|---|---|
b2g-master | --- | verified |
People
(Reporter: autra, Assigned: autra)
References
Details
(Keywords: regression)
Attachments
(2 files)
[Steps] - call someone - click on the keyboard button - observe the animation [Expected] - it slides up. [Actual] - there is no transition, ie it moves instantaneously. Appears to be broken by https://github.com/mozilla-b2g/gaia/pull/29562
Assignee | ||
Updated•9 years ago
|
Blocks: fastandfurious
Keywords: regression
Assignee | ||
Comment 1•9 years ago
|
||
We just need to include gaia-theme.css somewhere. I might submit a patch later today.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → augustin.trancart
Comment 2•9 years ago
|
||
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8648057 [details] [review] [gaia] autra:bug-1193172 > mozilla-b2g:master Hi Tamara, please r?
Attachment #8648057 -
Flags: review?(thills)
Comment 4•9 years ago
|
||
Hi Augustin, I had a quick question. I tested out and it adds the transition when the keypad comes up. I'm just curious if it supposed to transition the same way when the keypad goes down. I don't see a transition there. Thanks, -tamara
Flags: needinfo?(augustin.trancart)
Assignee | ||
Comment 5•9 years ago
|
||
There was no transition when the keypad goes down, before the regression or even in 2.2 (I've just checked). It would be nice to have one btw :-D
Flags: needinfo?(augustin.trancart)
Comment 6•9 years ago
|
||
Comment on attachment 8648057 [details] [review] [gaia] autra:bug-1193172 > mozilla-b2g:master Hi Augustin, It looks good. It might be good to file a follow up bug to add the transition for closing the keypad... as a new feature. Thanks, -tamara
Attachment #8648057 -
Flags: review?(thills) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 7•9 years ago
|
||
Ok, I opened https://bugzilla.mozilla.org/show_bug.cgi?id=1195679
Comment 8•9 years ago
|
||
Master: https://github.com/mozilla-b2g/gaia/commit/8a04afbf96aca0f4a4ddc53ff5deaafbcc2cc6ab
Status: NEW → RESOLVED
Closed: 9 years ago
status-b2g-master:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S5 (21Aug)
Comment 9•9 years ago
|
||
This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0. Actual results: When opening the keyboard in callscreen, the keyboard shows the transition. See attachment: verified_FlameKK_v2.5.3gp Reproduce rate: 0/10 Device: Flame KK 2.5 (Pass) Build ID 20150819030215 Gaia Revision 1e1197e0e8e64307aa382ffba4711d1c661de7ca Gaia Date 2015-08-18 16:54:35 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/f384789a29dcfd514d25d4a16a97ec5309612d78 Gecko Version 43.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150819.063618 Firmware Date Wed Aug 19 06:36:31 EDT 2015 Firmware Version v18D v4 Bootloader L1TC000118D0 Device: Aries KK 2.5(Pass) Build ID 20150820005800 Gaia Revision 89e0096a3de0378e3eda77e6a2a0bb5ca03eb8bb Gaia Date 2015-08-19 18:28:14 Gecko Revision https://hg.mozilla.org/integration/mozilla-inbound/rev/29b2df16e961fbe9a379362ecba6f888d1754bc3 Gecko Version 43.0a1 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20150820.002839 Firmware Date Thu Aug 20 00:28:46 UTC 2015 Bootloader s1
Comment 10•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•