1193438 - Error: failed to create an instance of @mozilla.org/chat/irc;1: SyntaxError: class is a reserved identifier

Status: VERIFIED FIXED

(Chat Core :: IRC, defect)

Description

[Stefan Sitter [:ssitter]]

Got upgraded from Earlybird 41.0a2 to Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0) Gecko/20100101 Thunderbird/42.0a2 (BuildID 20150811004004) today. Now the following error is logged in console after each startup:

Error: failed to create an instance of @mozilla.org/chat/irc;1: SyntaxError: class is a reserved identifier
Source File: resource://gre/components/imCore.js
Line: 349

Comment 1

[Patrick Cloke [:clokep]]

http://hg.mozilla.org/releases/comm-aurora/file/4c5cdd846354/chat/components/src/imCore.js#l349

This is just a Cu.reportError line, of course.

My first guess is bug 1142337 not working on aurora for some reason. I'm trying to find what could have thrown that string.

Comment 2

[Patrick Cloke [:clokep]]

We need to back out bug 1142337:

2:35:00 PM - clokep_work: Hey, quick question...the class keyword in JavaScript...is that disabled on aurora? It seemed to exist on 42 when it was in nightly?
2:35:44 PM - shu: clokep_work: ES6 features that currently being implemented are going to be nightly only for now, IIRC
2:35:57 PM - shu: clokep_work: so they will continue to be available in nightly, but get cut off during uplift
2:36:14 PM - clokep_work: shu: Interesting, how do they get cut out? Is that documented somewhere?
2:36:44 PM - shu: clokep_work: not documented unfortunately
2:36:51 PM - clokep_work: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes says "Nightly" but the link is useless...I don't want to download a "Nightly", I want to know "why/where/how/when" :)
2:36:58 PM - clokep_work: Bah OK.
2:37:08 PM - clokep_work: We landed something using it and it broke in aurora. :(
2:37:23 PM - clokep_work: shu: Thanks for the help!

Thanks for reporting this. aleth any ideas of whether you want to do a straight backout on aurora+nightly or just aurora? (I suspect both.)

Comment 3

[aleth [:aleth]]

Backed out bug 1142337, should be fixed now.

Comment 4

[Stefan Sitter [:ssitter]]

I can confirm that the error is gone in Earlybird 42.0a2 (20150812004004).