Closed
Bug 1193715
Opened 9 years ago
Closed 9 years ago
TalosParser should set self.complete after finding a TALOSDATA line
Categories
(Tree Management :: Treeherder: Data Ingestion, defect, P2)
Tree Management
Treeherder: Data Ingestion
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
Details
Attachments
(1 file)
ArtifactBuilderBase.parse_line() checks to see if a parser has declared itself as complete - and if so, does does get run against subsequent lines. TalosParser is looking specifically for the TALOSDATA line, so once it has found it (and presuming there will never be more than one TALOSDATA line within the file), it should declare itself complete, to save trying to match the TALOSDATA regex against every later line. Inspection of the talos tp5 jobs (eg https://treeherder.mozilla.org/logviewer.html#?job_id=12774257&repo=mozilla-inbound) - which have multiple subtests, confirm that they still only have one TALOSDATA line.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8646889 -
Flags: review?(wlachance)
Assignee | ||
Updated•9 years ago
|
Attachment #8646889 -
Attachment description: Stop running TalosParser against lines once TALOSDATA seen → Mark TalosParser complete once the TALOSDATA log line seen
Comment 2•9 years ago
|
||
Comment on attachment 8646889 [details] [review] Mark TalosParser complete once the TALOSDATA log line seen This makes sense, thanks!
Attachment #8646889 -
Flags: review?(wlachance) → review+
Comment 3•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/43bf7d3410e24d6a9c7b94a3deb3ac4addc9a848 Bug 1193715 - Mark TalosParser complete once the TALOSDATA log line seen There is only ever one TALOSDATA line in a log file, so once it has been seen there is no need to run TalosParser against later log lines. https://github.com/mozilla/treeherder/commit/7ffaf8c4827688d9ccd74f99fa76b86ff1a966b4 Merge pull request #864 from mozilla/stop-talosdata-parser-once-seen Bug 1193715 - Mark TalosParser complete once the TALOSDATA log line seen
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•