Closed
Bug 1193804
Opened 9 years ago
Closed 9 years ago
break up treeherder.css into logical smaller files
Categories
(Tree Management :: Treeherder, defect, P3)
Tree Management
Treeherder
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: camd, Assigned: jfrench)
Details
Attachments
(8 files)
46 bytes,
text/x-github-pull-request
|
camd
:
review+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
camd
:
review+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
camd
:
review+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
camd
:
review+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
camd
:
review+
|
Details | Review |
46 bytes,
text/x-github-pull-request
|
camd
:
review+
|
Details | Review |
47 bytes,
text/x-github-pull-request
|
camd
:
review+
|
Details | Review |
47 bytes,
text/x-github-pull-request
|
camd
:
review+
|
Details | Review |
we could likely break this up into sections like this (perhaps) general/common identifiers custom buttons header (nav bar, watched repos bar stuff) plugins (bottom) panel perhaps even separate jobs from revisions? Not sure... or... use your imagination. :)
Assignee | ||
Comment 1•9 years ago
|
||
I'll take this, and do it at a time after we land job counts and don't have a lot of css changes underway.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
Priority: -- → P3
Assignee | ||
Comment 2•9 years ago
|
||
Will mentioned it would be worthwhile to check to see if there's any grouping conventions, I haven't found anything definitive in searches so far. I did check Marketplace and it seems to tailor its groupings for its own needs. https://github.com/mozilla/fireplace/tree/master/src/media/css Proposing for treeherder we could have: css/treeherder-global.css css/treeherder-navbar.css css/treeherder-menus.css css/treeherder-resultsets.css css/treeherder-buttons.css css/treeherder-info-panel.css (includes pinboard, or we could split this out) css/treeherder-filters.css css/treeherder-result-status.css (includes our '-shading' color classes) css/treeherder-help.css And potentially bundle/minify the css during build(?) if we can quantify sufficient performance benefit.
Assignee | ||
Comment 3•9 years ago
|
||
There's a lot of css changes in camd's job grouping bug 1163064 and in my 'unknown jobs/steps' bug 1192917 which are both close to being done, so we'd like to land those first before I start splitting.
Assignee | ||
Comment 4•9 years ago
|
||
Ok, ready to go. I plan to do the change in separate PR's, one for each file. It should make it quick to land, easy to review, and prevent resolves.. vs. doing the entire break up over a longer period during which css changes may land.
Assignee | ||
Comment 5•9 years ago
|
||
PR for userguide for review.
Attachment #8656828 -
Flags: review?(cdawson)
Reporter | ||
Comment 6•9 years ago
|
||
Comment on attachment 8656828 [details] [review] PR 939 - userguide lgtm. :)
Attachment #8656828 -
Flags: review?(cdawson) → review+
Comment 7•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/b7b28f0f8e3d653485ca4348a3b85abb4b74fed0 Bug 1193804 - break up treeherder.css - userguide.css
Assignee | ||
Comment 8•9 years ago
|
||
(In reply to Jonathan French (:jfrench) from comment #2) > css/treeherder-filters.css I will probably change this to '-panels' when I get to it, it will include the filter panel, the sheriff panel, and also any future ones we create. Our main Info Panel (aka. pluginpanel) will still get its own file.
Assignee | ||
Comment 9•9 years ago
|
||
PR for navbar for review.
Attachment #8657884 -
Flags: review?(cdawson)
Reporter | ||
Updated•9 years ago
|
Attachment #8657884 -
Flags: review?(cdawson) → review+
Comment 10•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/af0ae5e926a74c01f6b6a33c2bc6f2c163fcd679 Bug 1193804 - Break up treeherder.css - navbar.css
Assignee | ||
Comment 11•9 years ago
|
||
(In reply to Jonathan French (:jfrench) from comment #2) > css/treeherder-filters.css Going with css/treeherder-navbar-panels.css for this; it's more generalized and we will include the sheriff panel.
Assignee | ||
Comment 12•9 years ago
|
||
PR for navbar-panels for review.
Attachment #8658822 -
Flags: review?(cdawson)
Reporter | ||
Updated•9 years ago
|
Attachment #8658822 -
Flags: review?(cdawson) → review+
Comment 13•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/5ca2e89f37f3969df4f51f143351d429d79198d0 Bug 1193804 - Break up treeherder.css - navbar-panels.css
Assignee | ||
Comment 14•9 years ago
|
||
> css/treeherder-buttons.css
Going with '-job-buttons' for this one (one of the main motivations for the splitting), and to differentiate from other buttons which will end up in other files.
Assignee | ||
Comment 15•9 years ago
|
||
PR for job-buttons for review.
Attachment #8660729 -
Flags: review?(cdawson)
Reporter | ||
Updated•9 years ago
|
Attachment #8660729 -
Flags: review?(cdawson) → review+
Comment 16•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/42bbf9383c04ba0ae44c73da1b3fc8f67be3bab2 Bug 1193804 - Break up treeherder.css - job-buttons.css
Assignee | ||
Comment 17•9 years ago
|
||
Adding a '-pinboard' to split it out separately from the info-panel.
Assignee | ||
Comment 18•9 years ago
|
||
PR for -pinboard for review.
Attachment #8662965 -
Flags: review?(cdawson)
Reporter | ||
Updated•9 years ago
|
Attachment #8662965 -
Flags: review?(cdawson) → review+
Comment 19•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/afe16b0c000296877595706fc000a074f8d9e8e5 Bug 1193804 - Break up treeherder.css - pinboard.css
Assignee | ||
Updated•9 years ago
|
Attachment #8662965 -
Attachment description: PR 975 → PR 975 - pinboard
Assignee | ||
Comment 20•9 years ago
|
||
PR for info-panel for review.
Attachment #8663800 -
Flags: review?(cdawson)
Reporter | ||
Updated•9 years ago
|
Attachment #8663800 -
Flags: review?(cdawson) → review+
Comment 21•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/5702a40a10874810cfefbcce31c5b84bfe7bfe63 Bug 1193804 - Break up treeherder.css - info-panel.css
Assignee | ||
Comment 22•9 years ago
|
||
PR for -resultsets for review.
Attachment #8664976 -
Flags: review?(cdawson)
Reporter | ||
Comment 23•9 years ago
|
||
Comment on attachment 8664976 [details] [review] PR 1000 - resultsets awesome. thanks for doing this!!
Attachment #8664976 -
Flags: review?(cdawson) → review+
Comment 24•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/7ace34b09bc62ca156a1d02d20c0d15e6a412bef Bug 1193804 - Break up treeherder.css - resultsets.css
Assignee | ||
Comment 25•9 years ago
|
||
PR for -global for review.
Attachment #8666126 -
Flags: review?(cdawson)
Reporter | ||
Updated•9 years ago
|
Attachment #8666126 -
Flags: review?(cdawson) → review+
Comment 26•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/82f45f74d1fef4b6d90b89cde16917e5c86d8583 Bug 1193804 - Break up treeherder.css - global.css
Assignee | ||
Updated•9 years ago
|
Attachment #8664976 -
Attachment description: PR 1000 → PR 1000 - resultsets
Assignee | ||
Updated•9 years ago
|
Attachment #8666126 -
Attachment description: PR 1008 → PR 1008 - global
Assignee | ||
Comment 27•9 years ago
|
||
Ok, I think we are done for now, marking fixed per above 8 merges. Many are already on stage/prod, the remaining ones will arrive there soon.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 28•9 years ago
|
||
Everything has been deployed to stage and it looks fine there (and matches prod) so marking Verified fixed.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•