1193830 - Clicking on the icon to mute then unmute (or unmute then mute) without moving the mouse off the icon switches tabs

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Clicking on the icon to mute then unmute (or unmute then mute) without moving the mouse off the icon switches tabs.

We shouldn't switch tabs if the audio icon is being clicked. I think this is the result of the `_overPlayingIcon` becoming false when the button is clicked, and it not being true when the icon is clicked a second time causing the tab to get switched to.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

I ran browser/base/content/test/general/browser_tabAudioIcon.js locally.
Browser Chrome Test Summary
        Passed: 86
        Failed: 0
        Todo: 0

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

[Tracking Requested - why for this release]:
Tab audio icons are shipping in 42, and I want to make sure this doesn't get forgotten.

Comment 4

[:Gijs (he/him)]

Comment on attachment 8647017 [details] [diff] [review]
Patch

Review of attachment 8647017 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d63ef58573ca

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Backed out for bustage:

https://hg.mozilla.org/integration/fx-team/rev/0ab25f8c278f

TEST-UNEXPECTED-FAIL | unknown test url | uncaught exception - TypeError: soundPlayingIcon is null at chrome://browser/content/tabbrowser.xml:5880

(and similar other failures)

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/879d3f7ab245

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/879d3f7ab245

Comment 9

[(no longer active)]

Jared, do you want to uplift this to Aurora?

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8647017 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: icon for tab audio
[User impact if declined]: various bugs related to the icon not responding to clicks or tabs becoming unselectable
[Describe test coverage new/current, TreeHerder]: automated tests cover tab audio indicator
[Risks and why]: none expected, removes some manual state tracking
[String/UUID change made/needed]: none

Comment 11

[Sylvestre Ledru [:Sylvestre]]

New feature, tracking it.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8647017 [details] [diff] [review]
Patch

Want the new feature polished.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/76f8cfa41d91

Comment 14

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using Aurora 42.0a2 (buildID: 20150818004007) and Nightly 43.0a1 (buildID: 20150818030209).