1194329 - Expose raw ADI counts in public web API

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Peter Bengtsson [:peterbe]]

Make it available and white-listed in the public web API.

Comment 1

[Peter Bengtsson [:peterbe]]

Attachment: Link to Github pull-request: https://github.com/mozilla/socorro/pull/2948

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/b89ee43d36b91d21f3410191277c7dcc2495fa33
fixes bug 1194329 - Expose raw ADI counts in public web API

https://github.com/mozilla/socorro/commit/a4dda21dfb98041f8cca6126154d39c5f03c4fdc
Merge pull request #2948 from peterbe/bug-1194329-expose-raw-adi-counts-in-public-web-api

fixes bug 1194329 - Expose raw ADI counts in public web API

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Peter, do you have some doc on how to use it? I would like to use it for bug 1146863. thanks

Comment 4

[Peter Bengtsson [:peterbe]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #3)
> Peter, do you have some doc on how to use it? I would like to use it for bug
> 1146863. thanks

Please ask me again in a week or three. The ADI I exposed has to change slightly for the feature I'm working on that needs this (and was the reason for adding this).

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

peterbe, asking again now. We might want to use this data, is it available ? If so, at what url ?

Comment 6

[Peter Bengtsson [:peterbe]]

https://crash-stats.mozilla.com/api/#ADI
The only tricky thing is how to spell the platform. I think it's "Windows", "Mac OS X" or "Linux".

Comment 7

[Robert Kaiser]

Actually it's the "name"s of https://crash-stats.mozilla.com/api/Platforms/ :)

Is there a followup bug to expose ADI by build as well?

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Awesome, thanks!

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

Actually, one hitch - if I want to know about the beta channel and make this query
https://crash-stats.mozilla.com/api/ADI/?end_date=2016-03-17&platforms=Windows&product=Firefox&start_date=2016-03-17&versions=45.0b9&versions=45.0&versions=46.0b1
then the versions=45.0 for the RC build seems have ADI so big that it must be including the release channel.

Comment 10

[Peter Bengtsson [:peterbe]]

(In reply to Nick Thomas [:nthomas] from comment #9)
> Actually, one hitch - if I want to know about the beta channel and make this
> query
> https://crash-stats.mozilla.com/api/ADI/?end_date=2016-03-
> 17&platforms=Windows&product=Firefox&start_date=2016-03-17&versions=45.
> 0b9&versions=45.0&versions=46.0b1
> then the versions=45.0 for the RC build seems have ADI so big that it must
> be including the release channel.

Perhaps I don't understand the question but the ADI database is smart in that it notices versions ending with a 'b' [0]. Meaning if you pass `&version=46.0b` you'll get the same effect as doing `&version=46.0b1&version=46.0b2&version=46.0b3...`

[0] https://github.com/mozilla/socorro/blob/989302330d4cdf34855d719698825f20d08461a5/socorro/external/postgresql/adi.py#L53

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

That's a nice simplification. But what'd I'd really like is to be able to say &channel=beta and ignore anyone on 45.0 with channel=release. Is that doable ?

Comment 12

[Nick Thomas [:nthomas] (UTC+12)]

Oh, I think I get what you mean now - https://crash-stats.mozilla.com/api/ADI/?end_date=2016-03-17&platforms=Windows&product=Firefox&start_date=2016-03-17&versions=45.0b&versions=46.0b gives me an entry for 45.0b99, the special way Socorro keeps track of RC builds on the beta channel.

Is there any way to look up the ESR builds like 45.0.1esr, or 38.7.1esr ? I can't find them with out without the 'esr' suffix.

Comment 13

[Robert Kaiser]

(In reply to Nick Thomas [:nthomas] from comment #12)
> Is there any way to look up the ESR builds like 45.0.1esr, or 38.7.1esr ? I
> can't find them with out without the 'esr' suffix.

ESR tracking doesn't work right on Socorro, IIRC. AFAIK there's a bug on that somewhere. We probably should fix that at some point but ESR has always been low priority.