1194524 - Use channel->ascynOpen2 in dom/media/MediaResource.cpp

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1194524_asyncopen2_mediaresource.patch

Jonas, I suppose we potentially need to set 'SEC_REQUIRE_CORS_DATA_INHERITS' in both cases, not just in one, right? And the other question I have, aren't we missing a contentPolicy check somewhere?

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 8660246 [details] [diff] [review]
bug_1194524_asyncopen2_mediaresource.patch

Review of attachment 8660246 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, setting it in both places looks correct.

::: dom/media/MediaResource.cpp
@@ +861,1 @@
>    }

You don't need the ChannelShouldInheritPrincipal call or the FORCE_INHERIT. The *_DATA_INHERITS modes take care of that.

@@ +1437,5 @@
>                                                      mURI,
>                                                      false, // aInheritForAboutBlank
>                                                      false // aForceInherit
>                                                      )) {
> +    securityFlags |= nsILoadInfo::SEC_FORCE_INHERIT_PRINCIPAL;

Same here.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f737c4a01752

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f737c4a01752