Closed
Bug 1194570
Opened 9 years ago
Closed 9 years ago
Mismatch between clients and tabs collection can cause failures to sync tabs
Categories
(Firefox for iOS :: Sync, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | + | --- |
People
(Reporter: rnewman, Assigned: rnewman)
Details
Attachments
(1 file)
If tabs contains a record that doesn't have a corresponding client record: 2015-08-13 19:32:50.151 [Info] [TabsSynchronizer.swift:88] doInsert: Inserting 1 tabs for client yPXUXf8u21cQ. 2015-08-13 19:32:50.152 [Debug] [SwiftData.swift:133] transaction: Op in transaction failed. Rolling back. 2015-08-13 19:32:50.152 [Warning] [TabsSynchronizer.swift:91] doInsert: Inserting tabs failed for client yPXUXf8u21cQ This'll cause the sync to be marked as failed.
|
Assignee | |
Updated•9 years ago
|
Summary: Mismatch between clients and tabs collection can cause client failures → Mismatch between clients and tabs collection can cause failures to sync tabs
|
|
Assignee | |
Comment 1•9 years ago
|
||
Thorough review, please. Last commit not strictly necessary.
Attachment #8647882 -
Flags: review?(sleroux)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8647882 [details] [review] Pull req. Code looks good with some nits and a question at the end. Curious if returning 0 will effect any other call sites.
Attachment #8647882 -
Flags: review?(sleroux) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
https://github.com/mozilla/firefox-ios/commit/36925be305062f43e9ee56b69f46514ef2d88273
You need to log in
before you can comment on or make changes to this bug.
Description
•