Closed
Bug 1194708
Opened 9 years ago
Closed 9 years ago
SPS not properly detected in some videos
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla43
People
(Reporter: jya, Assigned: jya)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.45 KB,
patch
|
ajones
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
A H264 NAL is made of: From Rec. ITU-T H.264 7.4.1 NAL unit semantics * forbidden_zero_bit shall be equal to 0 (1 bit) * nal_ref_idc not equal to 0 specifies that the content of the NAL unit contains a sequence parameter set, a sequence parameter set extension, a subset sequence parameter set, a picture parameter set, a slice of a reference picture, a slice data partition of a reference picture, or a prefix NAL unit preceding a slice of a reference picture. (2 bits) * nal_unit_type (5 bits) We always assumed that nal_ref_idc was set to 11. This can cause the SPS to not be found in some videos (BBC)
Assignee | ||
Comment 1•9 years ago
|
||
With some encoding, we didn't detect the SPS. With AVC3 stream it would cause playback to never start on mac or linux (ffmpeg)
Attachment #8648054 -
Flags: review?(ajones)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jyavenard
Updated•9 years ago
|
Attachment #8648054 -
Flags: review?(ajones) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8648054 [details] [diff] [review] Properly find SPS NAL in some H264 streams. Approval Request Comment [Feature/regressing bug #]: 1128381 [User impact if declined]: Media won't play. BBC videos won't start. [Describe test coverage new/current, TreeHerder]: Locally tested, inbound [Risks and why]: Extremely low; this is just implementing the spec more accurately. [String/UUID change made/needed]: None
Attachment #8648054 -
Flags: approval-mozilla-beta?
Attachment #8648054 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
status-firefox41:
--- → affected
status-firefox42:
--- → affected
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/13b813170d8e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Comment 5•9 years ago
|
||
Comment on attachment 8648054 [details] [diff] [review] Properly find SPS NAL in some H264 streams. Improve the media situation, taking it.
Attachment #8648054 -
Flags: approval-mozilla-beta?
Attachment #8648054 -
Flags: approval-mozilla-beta+
Attachment #8648054 -
Flags: approval-mozilla-aurora?
Attachment #8648054 -
Flags: approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•