1194824 - Add a "last_modified" column to exclusion profiles table

Status: RESOLVED FIXED

(Tree Management :: Treeherder: API, defect, P3)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'd like it if exclusion profiles returned a timestamp of the most recent time they were updated.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This would help me do things like notify all clients when the active exclusion profiles have been update <somewhere else>, prompting them to refresh to pick up the new changes.

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Mauro said he'd take a look at this sometime next week, because Mauro is good people. :)

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Mauro, ping? :)

Comment 4

[Mauro Doglio [:mdoglio]]

Attachment: PR 957

Comment 5

[Mauro Doglio [:mdoglio]]

To land this on staging/production we need a bit of coordination because there's a db change.

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/120ae4fadac274e59c20c1ab671d628417be3961
Bug 1194824 - Add last modified timestamp to ExclusionProfile

Comment 7

[Mauro Doglio [:mdoglio]]

I applied these db schema changes to both staging and production:
alter table `exclusion_profile` add column `modified` datetime default CURRENT_TIMESTAMP;
alter table `exclusion_profile` modify column `modified` datetime NOT NULL;

Comment 8

[Mauro Doglio [:mdoglio]]

I actually set `DEFAULT CURRENT_TIMESTAMP` so that we don't get errors before we land the code:
alter table `exclusion_profile` modify column `modified` datetime default CURRENT_TIMESTAMP;

Comment 9

[Ed Morley [:emorley]]

(In reply to Mauro Doglio [:mdoglio] from comment #7)
> I applied these db schema changes to both staging and production:

Could you also update Heroku's RDS instance please :-)

Comment 10

[Mauro Doglio [:mdoglio]]

Ooops I forgot about the heroku deployment. Done.

Comment 11

[Ed Morley [:emorley]]

Thank you :-)