Closed
Bug 1194962
Opened 9 years ago
Closed 9 years ago
Remove border-radius from the identity box
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: dao, Assigned: martianwars, Mentored)
Details
(Whiteboard: [good first bug][lang=css])
Attachments
(1 file, 1 obsolete file)
1.01 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/mozilla-central/annotate/2ddfc9180971/browser/themes/windows/browser.css#l1456 This was meant to accommodate to the location bar's border-radius, but that border-radius is only 1px now which means that the inner edge of the border is pretty much rectangular. So the identity box should be rectangular too. Note that this is only visible in popup windows.
Assignee | ||
Comment 1•9 years ago
|
||
Hi :dao, I am interested in this bug. Could I work on it? I have submitted a patch earlier but it hasn't been approved as yet. It wasn't mentored either.
Reporter | ||
Comment 2•9 years ago
|
||
(In reply to Kalpesh Krishna from comment #1) > Hi :dao, I am interested in this bug. Could I work on it? Sure!
Assignee | ||
Comment 3•9 years ago
|
||
So I have to simply remove all four border radius attributes right?
Reporter | ||
Comment 4•9 years ago
|
||
(In reply to Kalpesh Krishna from comment #3) > So I have to simply remove all four border radius attributes right? yes
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #8648472 -
Flags: review?(dao)
Reporter | ||
Comment 6•9 years ago
|
||
Comment on attachment 8648472 [details] [diff] [review] cssfixborder.patch > #identity-box:-moz-locale-dir(ltr) { >- border-top-left-radius: 1.5px; >- border-bottom-left-radius: 1.5px; > } > > #identity-box:-moz-locale-dir(rtl) { >- border-top-right-radius: 1.5px; >- border-bottom-right-radius: 1.5px; > } Please remove both rules entirely.
Attachment #8648472 -
Flags: review?(dao)
Assignee | ||
Comment 7•9 years ago
|
||
Attachment #8648513 -
Flags: review?(dao)
Reporter | ||
Comment 8•9 years ago
|
||
Comment on attachment 8648513 [details] [diff] [review] cssborderfix.patch Thanks!
Attachment #8648513 -
Flags: review?(dao) → review+
Reporter | ||
Updated•9 years ago
|
Assignee: nobody → kalpeshk2011
Reporter | ||
Updated•9 years ago
|
Attachment #8648472 -
Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/6abcc952af87
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
You need to log in
before you can comment on or make changes to this bug.
Description
•