Closed Bug 1195071 Opened 9 years ago Closed 9 years ago

MediaFormatReader should check the return value of MediaDataDecoder::Input

Categories

(Core :: Audio/Video: Playback, defect)

Product:
Core
Component:
Audio/Video: Playback
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla43
Tracking Flags:
Tracking Status
firefox42 --- fixed
firefox43 --- fixed

People

(Reporter: jya, Assigned: jya)

References

Details

Attachments

(1 file)

Check for MediaDataDecoder::Input error.
1.03 KB, patch
cpearce
: review+
Details | Diff | Splinter Review 
The MediaFormatReader doesn't check the return value of MediaDataDecoder::Input()

Most MediaDataDecoder always return NS_OK regardless of input ; however the H264Converter could potentially return an error.

The value should be checked.

Plus it's better form.

        Attachment #8648452 -
        Flags: review?(cpearce)

        Attachment #8648452 -
        Flags: review?(cpearce) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/6fc3ec170fb2
Assignee: nobody → jyavenard
Status: NEW → RESOLVED
Closed: 9 years ago

          status-firefox43:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43

    
  
Blocks: 1197083

    
    

    
  
Backed out for a youtube playback regression. See Bug 1199573.
https://hg.mozilla.org/releases/mozilla-aurora/rev/5bb661db5c6c
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago

          status-firefox42:
          fixed → affected
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: