1195110 - crash in @0x0 | mozilla::layers::CompositingRenderTargetOGL::~CompositingRenderTargetOGL()

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Johannes Pfrang [:johnp]]

This bug was filed from the Socorro interface and is 
report bp-00e63b79-d80b-4130-9c91-1963b2150816.
=============================================================

Crash with latest Fedora 22 KDE using pretty much all experimental layers features (APZ, acceleration forced, use-image-offscreen-surfaces). No STR.

Happened two times already. Here's the previous report (August 1st):

bp-3555e5a8-bbff-45b4-aafe-d7b452150801

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Looks like something bad is happening in the destructor. We should be able to figure out what by looking at the disassembly.

Comment 2

[Andrew Comminos [:acomminos]]

The only scenario I could find in the disassembly where we could jump to 0x0 would be if we're trying to call a symbol in a destroyed GLContext. The vtables of the participating classes seem sane.

We should modify the code here to check the result of GLContext::MakeCurrent before deleting the GL objects.

Comment 3

[Andrew Comminos [:acomminos]]

Attachment: Check if GLContext is destroyed before freeing resources in CompositingRenderTargetOGL.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6f9182aaadb1

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6f9182aaadb1