1195125 - Update to 38.2.0 reinstalled Lightning

Status: RESOLVED WORKSFORME

(Calendar :: General, defect)

Description

[Larry Gusaas]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/600.8.9 (KHTML, like Gecko) Version/8.0.8 Safari/600.8.9

Steps to reproduce:

Updated to Thunderbird 38.2.0. 
OS X ver. 10.10.5


Actual results:

Lightning was reinstalled in Extensions.
I had previously removed it after it was first installed as part of a previous update (the one that included it as a standard component.


Expected results:

Lightning should not have been reinstalled

Comment 1

[[:MakeMyDay]]

Just to be sure: you uninstalled Lightning manually in the add-ons manger and did not just use the offered option (on the lower notification bar) to disable it?

Comment 2

[Larry Gusaas]

(In reply to MakeMyDay from comment #1)
> Just to be sure: you uninstalled Lightning manually in the add-ons manger
> and did not just use the offered option (on the lower notification bar) to
> disable it?

I don't remember exactly what I did when Thunderbird first included Lightning.

Comment 3

[WaltS48 [:walts48]]

I did a couple of tests.

Test case #1

Installed a fresh copy of Thunderbird 38.0.1, started it with a fresh test profile.
Clicked Disable in the Notification bar informing me Lightning had been installed.
Another Notification bar displayed indicating Lightning would be removed and I needed to Restart Thunderbird.
Restarted Thunderbird and checked Add-ons manager, Lightning was disabled but not removed, clicked Remove and did not have to restart.
Restarted anyway to confirm Lightning was removed.
Selected Help > About Thunderbird and an update downloaded, was applied and restarted.
The update was 38.2.0 and Lightning was not reinstalled.

Test case #2

Installed a fresh copy of Thunderbird 38.0.1, started it with a fresh test profile.
Ignored the notification.
Opened Add-ons manager and removed Lightning, and restarted as directed.
Selected Help > About Thunderbird and an update downloaded, was applied and restarted.
The update was 38.2.0 and Lightning was not reinstalled.

Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0

Comment 4

[[:MakeMyDay]]

Thanks for testing. If you don't mind, can you please also test a fresh install of TB38.0.1, disable Lightning on on the notificationbar, restart and update to 38.2.0 (same as your tc#1 but without uninstalling Lightning)? That would be great.

Also, is there a way you know of to fool the updater by modifying some prefs to test the complete journey 38.0.1 - 38.1.0 - 38.2.0? If so, at least having your tc#2 tested in that way would be great as well.

Comment 5

[Larry Gusaas]

Test on Mac OS X

Comment 6

[WaltS48 [:walts48]]

(In reply to MakeMyDay from comment #4)
> Thanks for testing. If you don't mind, can you please also test a fresh
> install of TB38.0.1, disable Lightning on on the notificationbar, restart
> and update to 38.2.0 (same as your tc#1 but without uninstalling Lightning)?
> That would be great.
> 

Fresh install of TB38.0.1 and new test profile.
Disabled Lightning and restarted.
Checked and Lightning 4.0.0.1 was disabled.
Updated to TB 38.2.0 and restarted.
Lightning 4.0.2 was installed and enabled upon restart.

> Also, is there a way you know of to fool the updater by modifying some prefs
> to test the complete journey 38.0.1 - 38.1.0 - 38.2.0? If so, at least
> having your tc#2 tested in that way would be great as well.

No I don't.

Comment 7

[Tomasz Ostrowski]

The problem is that Thunderbird ignores mail.calendar-integration.opt-out preference on upgrade. This causes that even when a user removes Lightning it will be brought back on every update.

This is also a problem for system administrators, as they're unable to disable Lightning for all users using for example lockPref or similar mechanism. The only work-around I found was removing "distribution" folder from installation directory. But this would have to be done after every upgrade.

Comment 8

[[:MakeMyDay]]

mail.calendar-integration.opt-out is intended to persist the user decision for options offered in the notification bar, but it is actually not intended to be used for preventing a re-installation. For that, there's already a mechanism in toolkit.

You should have a boolean pref extensions.installedDistroAddon.{e2fda1a4-762b-4020-b5ad-a41df1933103} set to true in your profile, which is to prevent automated re-installation after uninstalling Lightning. That pref should have been created on initial distro addon installation of Lightning.

Everybody, who experienced the problem, can you please confirm this is existing and enabled? If it's not there, do you have removed that in any way?

If it's missing, in general, creating the same in an enabled state should prevent re-installation on next update after having uninstalled Lightning before.

However given the test result mentioned in comment #6 a disabled distro installed Lightning gets updated (expected) but enabled (unexpected). Enabling seems to happen at [1].

Walt, to confirm this, can you please repeat that test from comment #6 but enable pref extensions.logging.enabled in the config editor after initial installation and before updating to 38.2? After updating to 38.2, please attach the log messages from console appearing until TB is up and running.


[1] http://mxr.mozilla.org/comm-esr38/source/mozilla/toolkit/mozapps/extensions/internal/XPIProvider.jsm#3224

Comment 9

[[:MakeMyDay]]

Now that bug 1202173 has been resolved, the reference above must be 

http://mxr.mozilla.org/comm-esr38/source/mozilla/toolkit/mozapps/extensions/internal/XPIProvider.jsm#3038

Comment 10

[Tomasz Ostrowski]

Attachment: lightning-disabled.zip

This profile shows the bug. Lightning disabled on 38.1, shows again on 38.2.

Comment 11

[WaltS48 [:walts48]]

Attachment: errorlog.txt

Repeated test from Comment 6 with extensions.logging.enabled set to True, using the command line to originally start Thunderbird, so I could see errors and copy them from the Terminal application.

This time Lightning 4.0.2 was installed and disabled upon restart.

Comment 12

[[:MakeMyDay]]

Thanks Walt. So you was not able to repoduce the issue with your latest test. Has there been anything different compared to the test run before, when Lightning got reenabled except to debugging mode and start from cl?

@Thomasz: If you are able to reproduce the issue reliable, please provide a log as requested from Walt in comment #8.

Comment 13

[WaltS48 [:walts48]]

Attachment: errorlog2.txt

I was not able to reproduce the issue with yesterday's test. Only changes were some system updates.

Today is a new day.

Tested again as in comment 6 and reproduced the issue.

Tested from command line with extensions.logging.enabled still set to false and reproduced the issue.

Tested from command line with extensions.logging.enabled set to true and reproduced the issue.

All tests run with a new installs and new profiles after deleting them.

New error log attached.

I don't know what happened yesterday.

Comment 14

[Tomasz Ostrowski]

Attachment: extensions.logging.enabled while upgrading to thunderbird-38.2

I'm able to reproduce this today reliably (tried 4 times) on test user of my Fedora 21 Linux 64bit:

su - test

mkdir /var/tmp/bug1195125
cd /var/tmp/bug1195125
wget http://ftp.mozilla.org/pub/thunderbird/releases/31.8.0/linux-x86_64/en-US/thunderbird-31.8.0.tar.bz2
wget http://ftp.mozilla.org/pub/thunderbird/releases/38.1.0/linux-x86_64/en-US/thunderbird-38.1.0.tar.bz2
wget http://ftp.mozilla.org/pub/thunderbird/releases/38.2.0/linux-x86_64/en-US/thunderbird-38.2.0.tar.bz2

rm -fr ~test/.thunderbird

tar xjf thunderbird-31.8.0.tar.bz2
thunderbird/thunderbird
#click [I think I'll configure my account later]
#close
rm -fr thunderbird/

tar xjf thunderbird-38.1.0.tar.bz2
thunderbird/thunderbird
#click [I think I'll configure my account later]
#[Thunderbird now contains calendaring functionality by integrating the Lightning extension.] - click [Disable] click [Restart Now]
#click [I think I'll configure my account later]
#close
rm -fr thunderbird/

#in ~/.thunderbird/*.default/prefs.js verify that it contains:
  user_pref("mail.calendar-integration.opt-out", true);
  user_pref("extensions.installedDistroAddon.{e2fda1a4-762b-4020-b5ad-a41df1933103}", true);

#in ~/.thunderbird/*.default/prefs.js add:
  user_pref("extensions.logging.enabled", true);

tar xjf thunderbird-38.2.0.tar.bz2
thunderbird/thunderbird >thunderbird.log 2>&1

#calendar is enabled

Comment 15

[Wayne Mery (:wsmwk)]

Tomasz, Larry,

Can you still reproduce this??

Comment 16

[Larry Gusaas]

(In reply to Wayne Mery (:wsmwk) from comment #15)
> Tomasz, Larry,
> 
> Can you still reproduce this??

Updating Thunderbird does not reinstall Lightning any more. I have extensions.installedDistroAddon.{e2fda1a4-762b-4020-b5ad-a41df1933103} set to true.

Comment 17

[Wayne Mery (:wsmwk)]

Calendar add-on is now integrated with Thunderbird, so it is likely this issue should no longer occur and closing this bug report as a result.

Please comment if you are still seeing a problem when using a current version of Thunderbird.