1195362 - Quicksearch error pages ("foo is not a field" and friends) should still fill in search into quicksearch box

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Search, defect)

Description

[:Gijs (he/him)]

STR:

I have a bugzilla quicksearch bookmark keyword, so I can type things like:

bug prod:Firefox comp:Pref delta_ts>1d

to quickly search bugzilla.

Now if I make a typo, and type, for instance,


bug prodd:Firefox comp:Pref delta_ts>1d

I get an error page telling me:


> There is a problem with your search:
> prodd is not a valid field name.
> The legal field names are listed here.


That is all very well, but now the search I did does not appear in the quicksearch field at the top of bugzilla, and so I can't easily edit my search. I have to go into the URL bar and scan my (now URI-escaped) URI, which is a lot more hassle.

It would be nice if the failed query was still put in the quicksearch input box on the result page, even if it caused an error like this.

Comment 1

[David Lawrence [:dkl]]

Attachment: 1195362_1.patch

Comment 2

[:glob ✱]

Comment on attachment 8649254 [details] [diff] [review]
1195362_1.patch

Review of attachment 8649254 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

this looks good, except you missed the quicksearch_invalid_query error on line 172.
fix on commit please.

Comment 3

[David Lawrence [:dkl]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   4d855c2..df1f6c9  master -> master