Closed Bug 1195686 Opened 9 years ago Closed 6 years ago

[meta] Reduce usage of CPOW usage in storage inspector tests

Categories

(DevTools :: Storage Inspector, defect, P1)

defect

Tracking

(firefox43 affected)

RESOLVED FIXED
Tracking Status
firefox43 --- affected

People

(Reporter: miker, Assigned: miker)

References

Details

(Keywords: meta)

Priority: -- → P2
Whiteboard: [todo-mr]
Filter on HOTFROG.
Whiteboard: [todo-mr] → [todo-mr][t1]
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
OS: Unspecified → All
Hardware: Unspecified → All
Whiteboard: [todo-mr][t1]
This is a priority as platform is working on a new localStorage implementation and this means absolutely no CPOWs in Storage Inspector tests... no complaints as I have already begun the process of removing CPOWs.

My first instinct is to try to find some kind of flag we can set to completely disable CPOWs in our tests as this will prevent regressions.
Priority: P2 → P1
The complete list of Storage Inspector tests that reportedly contain CPOWs is:

  - browser_storage_basic_usercontextid_1.js
  - browser_storage_basic_usercontextid_2.js
  - browser_storage_basic_with_fragment.js
  - browser_storage_cache_delete.js
  - browser_storage_cache_error.js
  - browser_storage_cookies_add.js
  - browser_storage_cookies_delete_all.js
  - browser_storage_cookies_domain.js
  - browser_storage_cookies_domain_port.js
  - browser_storage_cookies_edit.js
  - browser_storage_cookies_edit_keyboard.js
  - browser_storage_cookies_samesite.js
  - browser_storage_cookies_tab_navigation.js
  - browser_storage_delete.js
  - browser_storage_delete_all.js
  - browser_storage_delete_tree.js
  - browser_storage_delete_usercontextid.js
  - browser_storage_dom_cache_disabled.js
  - browser_storage_dynamic_updates_cookies.js
  - browser_storage_dynamic_updates_localStorage.js
  - browser_storage_dynamic_updates_sessionStorage.js
  - browser_storage_empty_objectstores.js
  - browser_storage_indexeddb_delete.js
  - browser_storage_indexeddb_delete_blocked.js
  - browser_storage_indexeddb_duplicate_names.js
  - browser_storage_localstorage_add.js
  - browser_storage_localstorage_edit.js
  - browser_storage_localstorage_error.js
  - browser_storage_localstorage_rapid_add_remove.js
  - browser_storage_overflow.js
  - browser_storage_search.js
  - browser_storage_search_keyboard_trap.js
  - browser_storage_sessionstorage_add.js
  - browser_storage_sessionstorage_edit.js
  - browser_storage_sidebar.js
  - browser_storage_sidebar_toggle.js
  - browser_storage_sidebar_update.js
Also:

  - browser_storage_dynamic_windows.js
  - browser_storage_listings.js
  - browser_storage_updates.js
(In reply to Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe] from comment #5)
> My first instinct is to try to find some kind of flag we can set to
> completely disable CPOWs in our tests as this will prevent regressions.

When talking to :kmag, he suggested altering the CPOW safety check[1] could be useful for at least auditing where they all are.  This could be done for just unsafe CPOWs or all CPOWs.

With the changes in bug 1445551, the `uses-unsafe-cpows` annotation appears to mean that test file is loaded into sandbox with `Cu.permitCPOWsInScope` set.

[1]: https://searchfox.org/mozilla-central/rev/8976abf9cab8eb4661665cc86bd355cd08238011/js/ipc/JavaScriptParent.cpp#90
Summary: Reduce usage of CPOW usage in storage inspector tests → [meta] Reduce usage of CPOW usage in storage inspector tests
There are no longer any CPOWs in Storage Inspector tests... closing.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.