Closed Bug 1195869 Opened 9 years ago Closed 9 years ago

Refresh tabs in sidebar mode

Categories

(DevTools Graveyard :: WebIDE, defect)

defect
Not set
normal

Tracking

(firefox43 fixed)

RESOLVED FIXED
Firefox 43
Tracking Status
firefox43 --- fixed

People

(Reporter: jryans, Assigned: jfong)

References

Details

Attachments

(2 files, 1 obsolete file)

The sidebar mode has a known issue[1] with refreshing device tabs:

    // There are currently no available events to listen for when an unselected
    // tab navigates.  Since we show every tab's location in the project menu,
    // we re-list all the tabs each time the menu is displayed.
    // TODO: An event-based solution will be needed for the sidebar UI.

Since we're no longer clicking a button to show the project list in sidebar mode, there's no click event we can use as a signal to re-request updated tab info.

Let's try either a small refresh button next to the tabs header, or something similar to this, to resolve the issue in sidebar mode.

[1]: https://dxr.mozilla.org/mozilla-central/source/browser/devtools/webide/content/webide.js#1108
Attached patch Bug1195869.patch (obsolete) — Splinter Review
This seems to work. I'm unsure about my wording in the comment for showProjectPanel about removing that check if/when the dropdown mode is removed - if you have any suggestions on better wording, feel free to suggest one. 

Otherwise, let me know if that looks good. Uploading a screenshot next.
Attachment #8650105 - Flags: feedback?(jryans)
Attached image Firefox_WebIDE.png
Screenshot of new refresh tab button
Comment on attachment 8650106 [details]
Firefox_WebIDE.png

WFM!

(Could we set default icons for tabs/projects that don't have any?)
Attachment #8650106 - Flags: feedback+
Comment on attachment 8650105 [details] [diff] [review]
Bug1195869.patch

Review of attachment 8650105 [details] [diff] [review]:
-----------------------------------------------------------------

Overall I think it looks good!  The comment seems fine.

I'm with Alex though: can we make sure there are default icons?  It looks like tweaking `updateTabs` may do it.
Attachment #8650105 - Flags: feedback?(jryans) → feedback+
One thing to note is that running this in localruntime mode will result in an invalid favicon but a valid url.origin (chrome://webide).
Attachment #8651158 - Flags: review?(jryans) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6aea2f75ee30
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
    9.12 +<!ENTITY projectMenu_refreshTabs_label "Refresh Tabs">
    9.13 +<!ENTITY projectMenu_refreshTabs_accesskey "U">

You set an accesskey that's not available in the label, is this wanted?
Flags: needinfo?(jfong)
(In reply to Francesco Lodolo [:flod] from comment #9)
>     9.12 +<!ENTITY projectMenu_refreshTabs_label "Refresh Tabs">
>     9.13 +<!ENTITY projectMenu_refreshTabs_accesskey "U">
> 
> You set an accesskey that's not available in the label, is this wanted?

Ah, good catch! I'll follow up with that on another bug.
Flags: needinfo?(jfong)
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: