Closed
Bug 1195965
Opened 9 years ago
Closed 9 years ago
Remove #ifdefs from browser/components/tabview JS files
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(firefox43 fixed)
RESOLVED
FIXED
Firefox 43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: Gijs, Assigned: aryx)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
8.98 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
Hits: browser/components/tabview/search.js:#ifdef XP_MACOSX browser/components/tabview/search.js:#endif browser/components/tabview/search.js:#ifdef XP_MACOSX browser/components/tabview/search.js:#endif browser/components/tabview/ui.js:#ifdef XP_MACOSX browser/components/tabview/ui.js:#endif browser/components/tabview/ui.js:#ifdef XP_MACOSX browser/components/tabview/ui.js:#endif browser/components/tabview/ui.js:#ifdef XP_MACOSX browser/components/tabview/ui.js:#endif browser/components/tabview/ui.js:#ifdef XP_UNIX browser/components/tabview/ui.js:#else browser/components/tabview/ui.js:#endif browser/components/tabview/ui.js:#ifdef XP_MACOSX browser/components/tabview/ui.js:#endif browser/components/tabview/ui.js:#ifdef XP_UNIX browser/components/tabview/ui.js:#endif browser/components/tabview/ui.js:#ifdef XP_MACOSX browser/components/tabview/ui.js:#endif browser/components/tabview/ui.js:#ifdef XP_MACOSX browser/components/tabview/ui.js:#else browser/components/tabview/ui.js:#endif All of these are available on AppConstants.jsm
Assignee | ||
Comment 1•9 years ago
|
||
Assignee: nobody → aryx.bugmail
Status: NEW → ASSIGNED
Attachment #8650447 -
Flags: review?(gijskruitbosch+bugs)
Reporter | ||
Comment 2•9 years ago
|
||
Comment on attachment 8650447 [details] [diff] [review] patch, v1 Review of attachment 8650447 [details] [diff] [review]: ----------------------------------------------------------------- r=me with the nits below fixed & assuming green try ::: browser/components/tabview/search.js @@ +597,1 @@ > UI.setTitlebarColors({active: "#717171", inactive: "#EDEDED"}); Nit: It looks like this isn't a diff -w, which means both these lines need indenting ::: browser/components/tabview/ui.js @@ +988,5 @@ > if (evt.altKey) > return; > > + if ((AppConstants.platform == "macosx" && evt.metaKey) || > + (!(AppConstants.platform == "macosx") && evt.ctrlKey)) Nit: (AppConstants.platform != "macosx" && evt.ctrlKey) @@ +989,5 @@ > return; > > + if ((AppConstants.platform == "macosx" && evt.metaKey) || > + (!(AppConstants.platform == "macosx") && evt.ctrlKey)) > + { Nit: on the previous line at the end, not on its own line
Attachment #8650447 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/14e16174289b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•