1195975 - Mozmill and Jsbridge don't work with Firefox 42 due to add-on signing and release version 2.0.10.1

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Robert Kaiser]

Mozmill update tests like http://mm-ci-production.qa.scl3.mozilla.com:8080/job/ondemand_update/152895/ are failing because of add-on signing:

1439923436979	addons.xpi	WARN	Refusing to install staged add-on [e-mail] with signed state 0
1439923436988	addons.xpi	WARN	Refusing to install staged add-on [e-mail] with signed state 0

We'll need signed versions of the add-ons to be able to still run the tests.

This is currently hindering all update testing for the beta channel.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: jsbridge.xpi

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: mozmill.xpi

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Jorge, we have a problem running our Mozmill tests for the current 41.0b2 due to the add-on signing. Thing is none of those two add-ons are managed on AMO, whereby the mozmill one was a long time ago.

I tried to upload jsbridge to AMO but it failed due to no supported platform detected. Not sure what to do here. Also I'm not sure what will happen with Mozmill given that the formerly used addon has been marked as disabled. Not sure if it can be converted to an externally hosted addon.

Given the priority of the beta release can you please have a look? Thanks.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I want to add that Mozmill has reached its end of life and we only use it for update tests. So I don't really want to release a new version for both XPI. So getting the two attached extensions uploaded and signed would be great.

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

So, both XPIs are throwing an error because their compatibility is set to only toolkit, not a particular application. You just need to add something like this for AMO to accept them:

<em:targetApplication>
  <Description>
    <em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
    <em:minVersion>31.0</em:minVersion>
    <em:maxVersion>42.*</em:maxVersion>
  </Description>
</em:targetApplication>

If there are already on AMO and disabled, please give me their URLs and I'll let you know what needs to happen in order to get them signed.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Both add-ons have been uploaded and signed now. But as it turns out we would still have to release a new version of mozmill because the signed XPI needs to be downloaded. It will not work if the local extension is not signed. :(

Given that a new release of Mozmill would mean a version bump, I will release a minor release with version 2.0.10.1. That way we can keep the extension at version 2.0.10. The same would apply for jsbridge.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: fix

This patch updates our code with the signed extensions and also bumps the version numbers. Beside that i had to move the ant build file to an upper directory.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

https://github.com/mozilla/mozmill/commit/394e5e3169dbb6066ceaede8493a98f3349be672

Tagged 2.0.10.1 release:
https://github.com/mozilla/mozmill/commits/2.0.10.1

Released to pypi:

Submitting dist/jsbridge-3.0.3.1.tar.gz to https://pypi.python.org/pypi
Server response (200): OK

Submitting dist/mozmill-2.0.10.1.tar.gz to https://pypi.python.org/pypi
Server response (200): OK

All done here. Thanks everyone for the quick turnaround!

I will release a new version of mozmill-automation and the environments soon, so that Mozmill-CI can be updated.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sorry, but the 2.0.10.1 release is totally busted due to the mozlog 3.0 release which broke API compatibility. Even having strict dependencies in our own setup.py file, mozrunner 5.35 installed the latest mozlog release even it is incompatible. :( Sadly I found that after the release when I had to create a new virtualenv for mozmill-automation. I fill fix it in a follow-up bug.