1196144 - Clicking 'save file' after the source window has been navigated/closed brings up the "Save as..." window and immediately closes it

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect)

Description

[:Gijs (he/him)]

(see also: bug 918000)

STR:

1. ensure 'always ask me where to save files' is checked in the preferences
2. go to http://www.apple.com/itunes/download/
3. uncheck the checkboxes
4. click "download now"
5. wait with clicking 'save file' until you see the thank you page and that page has finished loading

ER:
"Save as" dialog letting you pick where to save the file

AR:
the dialog appears, but disappears immediately


I could only reproduce this on Windows, not on OS X.

Comment 1

[Robert Premuž]

I was able to reproduce this with Firefox 40.0.2 on MS Windows 7 but not on Linux Mint 17.2.

Comment 2

[f0rhum]

Same in FF41

Comment 3

[f0rhum]

Maybe a dup of bug 1115248 or depends on bug 1128480

Comment 4

[f0rhum]

More info for comment 2 : met downloading iTunes from Apple (with "Always ask..." set)

Comment 5

[:Gijs (he/him)]

(In reply to f0rhum from comment #4)
> More info for comment 2 : met downloading iTunes from Apple (with "Always
> ask..." set)

FWIW, it's not really helpful to comment on the fixed bugs without including the bug number for the open bug that we filed as a result (see last comments in bug 918000) - it just creates fear, uncertainty, doubt, etc.



I finally got around to look at this. There's a Windows-specific issue here where:

1) the window causing the download has gone away
2) we try to find a replacement parent window
3) we pick the "Save as" helper dialog (the small Firefox dialog with the "Save file" and "Cancel" buttons)
4) we try to show the Windows filepicker using that parent, but in the process we also close our own dialog.
5) the closing of our own dialog, with a 300ms delay because of some windows widget wizardry that apparently has to do with RTL ( https://dxr.mozilla.org/mozilla-central/rev/e5effeb8e57ceddf679f7784faab0c2cebb1e1e6/widget/windows/nsFilePicker.cpp#92-95 ), triggers auto-closing the Windows file picker

annnd we get what happens here. This doesn't happen on the other platforms because the widget filepicker implementations don't care about the parent window quite so much...

Comment 6

[:Gijs (he/him)]

(this doesn't happen on Nightly builds because e10s, and at the time I didn't use Windows for my testing, so nobody noticed this for a while...)

Comment 7

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1196144 - source window disappearance still breaks downloading to custom directories on windows, r?felipe

Bug 1196144 - source window disappearance still breaks downloading to custom directories on windows, r?felipe

Comment 8

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8666018 [details]
MozReview Request: Bug 1196144 - source window disappearance still breaks downloading to custom directories on windows, r?felipe

https://reviewboard.mozilla.org/r/20413/#review18353

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/a176223b1212

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a176223b1212

Comment 11

[:Gijs (he/him)]

Comment on attachment 8666018 [details]
MozReview Request: Bug 1196144 - source window disappearance still breaks downloading to custom directories on windows, r?felipe

Approval Request Comment
[Feature/regressing bug #]: n/a
[User impact if declined]: people who have Firefox configured to ask where to save files will have downloads fail if the originating window goes away.
[Describe test coverage new/current, TreeHerder]: I do not believe we have test coverage for this. :-(
[Risks and why]: very low - this is a straightforward patch that, instead of using the most recent window to parent the "save as" dialog, uses the most-recent-except-our-'what-do-you-want-to-do-with-this-file' window -- because otherwise the file dialog appears for a fraction of a second and then disappears again. ie it makes sure to skip one of the windows when looking for a window to parent against.
[String/UUID change made/needed]: no.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8666018 [details]
MozReview Request: Bug 1196144 - source window disappearance still breaks downloading to custom directories on windows, r?felipe

User facing regression, taking it.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0f1094755092

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/87eaa176fb4d

Comment 15

[Mihai Boldan, Desktop QA [:mboldan]]

Reproduced the initial issue on Win 7 x64 using Firefox 38.0.6 build following steps from comment 0. Verified that the issues does not reproduce on Firefox 42.0 Beta 3 (20151001142456).

Also verified as fixed using Latest Nightly 44.0a1 (2015-10-04) on the same test environment.