1196266 - Firefox title bar should pick up the Windows 10 accent color when in the foreground

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Verdi [:verdi] Best to slack me]

Windows 10 Build 10525 - http://blogs.windows.com/bloggingwindows/2015/08/18/announcing-windows-10-insider-preview-build-10525/ - includes the ability to display the system accent color in title bars when the window is active. This doesn't work in Firefox. The Firefox title bar stays gray whether it's in the foreground or background

Comment 1

[Verdi [:verdi] Best to slack me]

Attachment: titlebar.png

An example of Chrome using the system accent color for the title bar color.

Comment 2

[:Gijs (he/him)]

Wonderful. :-\

The accent color might be the same as the color we use for the tabs, though, in which case there would be no more contrast. What does Edge do in that case? (you can configure the color manually)

Comment 3

[Verdi [:verdi] Best to slack me]

Attachment: color list.png

It seems the feature is off by default at the moment. There are two options: 1. "Automatically choose an accent color from my background" and if you turn that off you can 2. "Choose your accent color" from a predefined list (doesn't seem to be a way to customize this list). It seems that the result is that any accent color is possible.

I don't know if this is the final behavior but Edge is not using the accent color in the title bar. IE, Chrome and other Windows apps (file explorer, News, Weather, Word Pad, etc.) are.

Comment 5

[Stephen Horlander [:shorlander]]

It doesn't seem that any of the "Modern" apps are using the color.

This is effectively the same behavior as Windows 8. Not sure we should do anything here. Having a predictable and static background color might win out over picking up a questionable (and currently optional) system customization.

In any case I think we should wait and see what the final implementation is.

Comment 6

[Tim Nguyen :ntim]

(In reply to Stephen Horlander [:shorlander] from comment #5)
> It doesn't seem that any of the "Modern" apps are using the color.
Not really, the apps that don't define their titlebar color (store) are affected.

> This is effectively the same behavior as Windows 8. Not sure we should do
> anything here. Having a predictable and static background color might win
> out over picking up a questionable (and currently optional) system
> customization.
One difference from Win8 is that black text is always readable since Win10 saturates the titlebar color to make sure black text is readable.
 
> In any case I think we should wait and see what the final implementation is.

Yeah, by the looks of the implémentation, things look unfinished right now.

Comment 7

[Tim Nguyen :ntim]

(In reply to Tim Nguyen [:ntim] (mostly away until 26 August) from comment #6)
> Yeah, by the looks of the implémentation, things look unfinished right now.
implementation* 
How did I sneak in accentuation there ?

Comment 8

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Just making sure this stays on our radar.
FWIW, our current implementation still looks really good even if the feature is enabled, so no need to rush :)

Comment 10

[leichixian]

Attachment: UserStyle to fix it

Write a userstyle to fix it.

Comment 11

[:Gijs (he/him)]

(In reply to leichixian from comment #10)
> Created attachment 8651580 [details]
> UserStyle to fix it
> 
> Write a userstyle to fix it.

This looks like it reshows the native titlebar buttons, which will cause issues on non100% dpi. (it also looks like it then shows the custom buttons over the top on hover, which I don't think will work reliably on different DPI settings, and potentially font settings (e.g. if the native caption size changes, I wonder if the buttons will change size too, and then the icons will shift or overlap because the custom buttons are semi-transparent...))

I expect the correct fix will be making the accent color available through CSS somehow.

Comment 12

[leichixian]

(In reply to :Gijs Kruitbosch from comment #11)
> (In reply to leichixian from comment #10)
> > Created attachment 8651580 [details]
> > UserStyle to fix it
> > 
> > Write a userstyle to fix it.
> 
> This looks like it reshows the native titlebar buttons, which will cause
> issues on non100% dpi. (it also looks like it then shows the custom buttons
> over the top on hover, which I don't think will work reliably on different
> DPI settings, and potentially font settings (e.g. if the native caption size
> changes, I wonder if the buttons will change size too, and then the icons
> will shift or overlap because the custom buttons are semi-transparent...))
> 
> I expect the correct fix will be making the accent color available through
> CSS somehow.

Okay, I have only one device, but I change dpi to 125% and it works okay. And I don't know your concern of custom buttons, because it just shows system native UI and Firefox native close button when you hover on it. As for padding setting, its calculated value is the same as served in browser.css from mozilla. I posted it on two forums and up till now I've received no issue.

Comment 13

[leichixian]

(In reply to :Gijs Kruitbosch from comment #11)
> (In reply to leichixian from comment #10)
> > Created attachment 8651580 [details]
> > UserStyle to fix it
> > 
> > Write a userstyle to fix it.
> 
> This looks like it reshows the native titlebar buttons, which will cause
> issues on non100% dpi. (it also looks like it then shows the custom buttons
> over the top on hover, which I don't think will work reliably on different
> DPI settings, and potentially font settings (e.g. if the native caption size
> changes, I wonder if the buttons will change size too, and then the icons
> will shift or overlap because the custom buttons are semi-transparent...))
> 
> I expect the correct fix will be making the accent color available through
> CSS somehow.

But if you don't deal with icons, the system native icon will be a bit offset from firefox icons, which will be very ugly. So it's not what I want* to do something with icon, but I have* to.

Comment 14

[Tim Nguyen :ntim]

(In reply to :Gijs Kruitbosch from comment #11) 
> I expect the correct fix will be making the accent color available through
> CSS somehow.

We'll need to make sure we saturate it like windows does.

Comment 15

[Matt Cosentino]

Instead of setting it to transparent I tried setting it to rgba(0,0,0,0.22). This makes it the same gray color we use now when inactive, so you can still distinguish the tabs from the background. The problem is that this makes the active color slightly darker. So I tried only setting that color on -moz-window-inactive, but there's a delay before that takes effect. Using the accent color through CSS would have the same problem with the -moz-window-inactive delay. This was a known issue back in the days of the Firefox button(https://bugzilla.mozilla.org/show_bug.cgi?id=594367) but it was ignored.

Comment 16

[Fusion Future]

Attachment: Incorrect behavior

DPI 200%

Comment 17

[leichixian]

(In reply to Fushan Wen from comment #16)
> Created attachment 8657405 [details]
> Incorrect behavior
> 
> DPI 200%

But I don't know how to deal with it. And I don't have the device to test under such situation.

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Just as a ping, the update that includes this feature just shipped out to everyone yesterday.

Comment 19

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

This feature has been implemented by Google Chrome and Internet Explorer (but not implemented yet by Edge).

Comment 20

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

And also implemented by Opera.

Comment 21

[leichixian]

(In reply to Masayuki Nakano [:masayuki] (Mozilla Japan) from comment #20)
> And also implemented by Opera.

In fact, all browsers with no self-drawing UI will use Windows default UI and will make the color of titlebar change as the system theme color change. Those browsers where self-drawing UI are used (like Edge and Firefox) will not be affected by system setting.

Comment 22

[Matt Cosentino]

(In reply to leichixian from comment #21)
> (In reply to Masayuki Nakano [:masayuki] (Mozilla Japan) from comment #20)
> > And also implemented by Opera.
> 
> In fact, all browsers with no self-drawing UI will use Windows default UI
> and will make the color of titlebar change as the system theme color change.
> Those browsers where self-drawing UI are used (like Edge and Firefox) will
> not be affected by system setting.

That's not entirely accurate. Firefox is affected by the system setting, it just draws over it. This is why the system titlebar color shows when the window background is set to transparent. Edge is a different story, as it is a modern app.

Comment 24

[My1]

@Matt Cosentino then please dont draw over it and let the system do its stuff, it usually knows best and modders dont have to worry about that weird stuff. in win7 and 8 it doesnt draw over as well so why need it in w10?

Comment 25

[Matt Cosentino]

(In reply to My1 from comment #24)
> @Matt Cosentino then please dont draw over it and let the system do its
> stuff, it usually knows best and modders dont have to worry about that weird
> stuff. in win7 and 8 it doesnt draw over as well so why need it in w10?

I'm not doing anything, I'm just saying what Firefox is doing. There are visibility issues with the tabs on top of the inactive titlebar, which was not an issue in 7 and 8.

Comment 26

[leichixian]

(In reply to Matt Cosentino from comment #25)
> (In reply to My1 from comment #24)
> > @Matt Cosentino then please dont draw over it and let the system do its
> > stuff, it usually knows best and modders dont have to worry about that weird
> > stuff. in win7 and 8 it doesnt draw over as well so why need it in w10?
> 
> I'm not doing anything, I'm just saying what Firefox is doing. There are
> visibility issues with the tabs on top of the inactive titlebar, which was
> not an issue in 7 and 8.

Can you give out a picture that some tabs are in such situation? Why dare chrome and IE support such function even if they know it has bug? I wonder in fact it is just about the UI of firefox itself.

Comment 27

[Matt Cosentino]

(In reply to leichixian from comment #26)
> (In reply to Matt Cosentino from comment #25)
> > (In reply to My1 from comment #24)
> > > @Matt Cosentino then please dont draw over it and let the system do its
> > > stuff, it usually knows best and modders dont have to worry about that weird
> > > stuff. in win7 and 8 it doesnt draw over as well so why need it in w10?
> > 
> > I'm not doing anything, I'm just saying what Firefox is doing. There are
> > visibility issues with the tabs on top of the inactive titlebar, which was
> > not an issue in 7 and 8.
> 
> Can you give out a picture that some tabs are in such situation? Why dare
> chrome and IE support such function even if they know it has bug? I wonder
> in fact it is just about the UI of firefox itself.

I wasn't saying it was a bug in Windows, it is about the UI in Firefox itself. I'm not saying anything new.

Comment 28

[Matt Cosentino]

Attachment: inactivetabs.png

Comment 29

[Matt Cosentino]

Attachment: activetabs.png

There is also a visibility issue when using a dark color for active windows, so this would need to be detected somehow and then change to using white text and white buttons. Windows does this with the min/max/close buttons.

Comment 30

[leichixian]

(In reply to Matt Cosentino from comment #29)
> Created attachment 8703357 [details]
> activetabs.png
> 
> There is also a visibility issue when using a dark color for active windows,
> so this would need to be detected somehow and then change to using white
> text and white buttons. Windows does this with the min/max/close buttons.

Okay I fully understood what you mean. Maybe we should add some code that can detect whether the color is too dark and use white text.

Comment 31

[:Gijs (he/him)]

(In reply to leichixian from comment #30)
> (In reply to Matt Cosentino from comment #29)
> > Created attachment 8703357 [details]
> > activetabs.png
> > 
> > There is also a visibility issue when using a dark color for active windows,
> > so this would need to be detected somehow and then change to using white
> > text and white buttons. Windows does this with the min/max/close buttons.
> 
> Okay I fully understood what you mean. Maybe we should add some code that
> can detect whether the color is too dark and use white text.

This code already exists and is used on Windows 8. I don't know if the same code works for Windows 10 because I don't know if the mechanism it uses is the same or not. You could try if using it works or not: https://dxr.mozilla.org/mozilla-central/rev/d7a0ad85d9fb77916f9d77d62697b852f3dc63e6/browser/base/content/browser.js#997-1018 .

Seems to me like this bug needs design work for the inactive window case, at least.

Comment 32

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Yes, this definitely needs design work. The Firefox UI just doesn't work with a white title bar (which is both the default on Windows 10 and the default for unfocused windows).
I don't think this is a high priority bug though, given that Edge (and many other Windows apps) are doing custom colors. Plus, the option to even switch on the colored title bars is still pretty hidden. Slotting it in in the QX queue.

Comment 34

[Matthew M]

Is there an add-on that substitutes for this functionality in the meantime? I find the grey title bar to just look ugly.

Comment 35

[Brandon Watkins]

(In reply to Matthew M from comment #34)
> Is there an add-on that substitutes for this functionality in the meantime?
> I find the grey title bar to just look ugly.

This theme: https://addons.mozilla.org/en-US/firefox/addon/simplewhitex/ plus this userstyle: https://userstyles.org/styles/126206/simple-white-theme-windows-10-colored-titlebar is the best I've found

Comment 36

[Matthew M]

(In reply to Brandon Watkins from comment #35)
> This theme: https://addons.mozilla.org/en-US/firefox/addon/simplewhitex/
> plus this userstyle:
> https://userstyles.org/styles/126206/simple-white-theme-windows-10-colored-
> titlebar is the best I've found

Thank you very much, worked perfectly!

Comment 37

[Stephen Horlander [:shorlander]]

Attachment: Windows 10 - Settings - Colors

If we want to properly support the Windows 10 color options we are probably going to need to know the status of the following system prefs:
- Show color on titlebar
- Choose your app mode: Light | Dark

If the accent color isn't being used we need to keep the current neutral grey appearance.

We will also need to be able to pull the system accent color and the corresponding color for text on top of it. E.g. if you pick a dark accent color the title turns white.

I don't believe we currently extract that color info?

Comment 38

[Stephen Horlander [:shorlander]]

Attachment: Example of using Accent Color for Titlebar

An example of how this is going to look.

Comment 39

[:Gijs (he/him)]

(In reply to Stephen Horlander [:shorlander] from comment #37)
> Created attachment 8766535 [details]
> Windows 10 - Settings - Colors
> 
> If we want to properly support the Windows 10 color options we are probably
> going to need to know the status of the following system prefs:
> - Show color on titlebar
> - Choose your app mode: Light | Dark

We don't have this info. I suspect it's just a registry setting, though it'd be useful to know which one.

> We will also need to be able to pull the system accent color and the
> corresponding color for text on top of it. E.g. if you pick a dark accent
> color the title turns white.
> 
> I don't believe we currently extract that color info?

We do on Windows 8, as noted in comment 31. I don't know if that code works on win10 without modifications.

What would we do on a background window?

Comment 40

[Stephen Horlander [:shorlander]]

(In reply to :Gijs Kruitbosch from comment #39)
> What would we do on a background window?

Other applications fall back to the default window color. We could (should) just fall back to the default grey color.

http://cl.ly/0f0F1p1s1y3z

Comment 41

[My1]

in my opinion you should just let the system handle the borders and stuff. It works nicely on all sytsems including win8 where I can even put on a win7 theme and it looks as it should, but since FF does it's own (in my opinion stupid) stuff that obviously doesnt work as well in w10.

Comment 42

[Peter]

I have been using Windows 10 for a few months and found that the clear indication of which was the active window made a significant improvement to usability over Windows 7. If you mainly use a mouse this is not obvious, but if you use the keyboard mainly then knowing which window is active is essential. I currently use about 12 applications regularly and Firefox is the only one that does not show which window is active. It is a major problem for me with usability. I will continue to use Firefox, but any way to indicate that Firefox is the active window on Windows 10 would be greatly appreciated. It is an issue of usability for me not aesthetics.

Comment 43

[Matthew M]

(In reply to Peter from comment #42)
> I have been using Windows 10 for a few months and found that the clear
> indication of which was the active window made a significant improvement to
> usability over Windows 7. If you mainly use a mouse this is not obvious, but
> if you use the keyboard mainly then knowing which window is active is
> essential. I currently use about 12 applications regularly and Firefox is
> the only one that does not show which window is active. It is a major
> problem for me with usability. I will continue to use Firefox, but any way
> to indicate that Firefox is the active window on Windows 10 would be greatly
> appreciated. It is an issue of usability for me not aesthetics.

https://bugzilla.mozilla.org/show_bug.cgi?id=1196266#c35

Though note that I've had success recently with just the UserStyle and the Default theme.

Comment 44

[Peter]

(In reply to Matthew M from comment #43)
> (In reply to Peter from comment #42)
> > I have been using Windows 10 for a few months and found that the clear
> > indication of which was the active window made a significant improvement to
> > usability over Windows 7. If you mainly use a mouse this is not obvious, but
> > if you use the keyboard mainly then knowing which window is active is
> > essential. I currently use about 12 applications regularly and Firefox is
> > the only one that does not show which window is active. It is a major
> > problem for me with usability. I will continue to use Firefox, but any way
> > to indicate that Firefox is the active window on Windows 10 would be greatly
> > appreciated. It is an issue of usability for me not aesthetics.
> 
> https://bugzilla.mozilla.org/show_bug.cgi?id=1196266#c35
> 
> Though note that I've had success recently with just the UserStyle and the
> Default theme.

The comment you linked to solved my problem perfectly. I now have the title bar on Firefox behaving the same as all other windows - dark blue when active, light grey when inactive.  I followed the instructions and installed Stylish extension, selected the "Simple White theme/Windows 10 Colored Titlebar" userstyles.org. This was enough to solve the problem, but I also installed the "Simple White X" theme - which looks better. I found one small problem - the 3 buttons (minimise, maximise, close) in the top right of the title bar are out of place ... but I don't use them much, so I can live with that. 

Thanks for your help.

Comment 45

[UK92]

(In reply to :Gijs Kruitbosch from comment #39)
> (In reply to Stephen Horlander [:shorlander] from comment #37)
> > Created attachment 8766535 [details]
> > Windows 10 - Settings - Colors
> > 
> > If we want to properly support the Windows 10 color options we are probably
> > going to need to know the status of the following system prefs:
> > - Show color on titlebar
> > - Choose your app mode: Light | Dark
> 
> We don't have this info. I suspect it's just a registry setting, though it'd
> be useful to know which one.

HKEY_CURRENT_USER\Software\\Microsoft\\Windows\\DWM

For color, just like in Windows8WindowFrameColor.jsm - "ColorizationColor" key, except without taking color balance into account.
And "ColorPrevalence" key to determinate if windows are colored.

I've been trying around this and problem is, how to re-trigger code when system color change.

Comment 46

[Xavier B]

Also, in HKEY_CURRENT_USER\Software\\Microsoft\\Windows\\DWM if ColorizationColor is set to 1 you should look at the AccentColor & AccentColorInactive to find out what active/inactive colors the title bar should be set to.

More details here:
http://www.tenforums.com/tutorials/32118-inactive-title-bar-color-change-windows-10-a.html

Comment 47

[My1]

but why mess with the title bar at all, it worked so great in previous versions where it didnt mess with the system theme like at all.

why even try to add a color normally when you can just let the system make the frame?

Comment 48

[Xavier B]

I would agree, but in this case it's somewhat useful because the tabs are part of the title bar and you save a bit of vertical space compared to (for example) Chrome which does it the "traditional" way.

Comment 49

[My1]

well at least for me on win8 I have no space waste on a maximized window. and a bit of vertical waste makes sense on a normal window because you need some space to grab with the mouse.

Comment 50

[Xavier B]

You are right, maximized chrome doesn't waste any space, but yet it uses the colors from HKEY_CURRENT_USER\Software\\Microsoft\\Windows\\DWM and/or lets the systemd draw the frame. That's what I want by default for Firefox & Thunderbird :)

Comment 51

[My1]

in my opinion FF should just let the system draw the frame like it does in ANY OTHER OS.

this also has the advantage that users who modded themselves with custom themes get to use those with firefox.

Comment 52

[Matt Cosentino]

The user styles posted let system draw the frame and just draws the tabs on top, and vertical space is no different. There are other issues that would need to be fixed, but it's certainly possible.

Comment 53

[My1]

why does it take so long to fix this? the simplest fix would be just removing any windows 10-specific actions done on the title bar. that also would resolve any issues if MS decides to change the theme someday.

Comment 54

[marczellm]

I think this might help.

https://www.codeproject.com/Articles/18910/Adding-or-Retrofitting-Aero-Glass-into-Legacy-Wind

I just experimented with this. If you download the sample binaries, the same window areas that are drawn with Aero Glass on Windows 7 get the accent color on Windows 10. So maybe, Firefox could simply extend the window frame and draw the tabs on top of that. The same or similar code path could be used on all supported Windows versions. I'm sure this is very close to what Firefox currently does on Vista/7.

Comment 55

[marczellm]

Attachment: Windows 7 Aero Glass surface = Windows 10 accent color

This is an illustration for my previous post

Comment 56

[Jonathan Watt [:jwatt]]

(In reply to Stephen Horlander [:shorlander] from comment #37)
> If we want to properly support the Windows 10 color options we are probably
> going to need to know the status of the following system prefs:
> - Show color on titlebar
> - Choose your app mode: Light | Dark

As far as I can tell the Light/Dark app mode does not affect the color that is used in the titlebar, so I don't think we need to worry about that. Or am I missing something?

Comment 57

[Jonathan Watt [:jwatt]]

(In reply to Stephen Horlander [:shorlander] from comment #38)
> Created attachment 8766536 [details]
> Example of using Accent Color for Titlebar

It looks like coloring background tabs with the accent color will cause issues with the favicons of background tabs. For example a green that's very similar to the green in the bugzilla favicon is available for users to choose. It may be better to make background tabs a transparent grey so that the accent color shows through a bit, but isn't too strong.

Comment 58

[My1]

@jwatt but why hasnt this been a problem in windows 8 at all?
it just nicely takes the titlebar we set and even if we mod in a custom theme Firefox adheres to that.

only on Windows 10 Firefox shows this titlebar behavior. Why not just reset this windows 10 specific junk and let the system do the theme?

Comment 59

[Stephen Horlander [:shorlander]]

(In reply to Jonathan Watt [:jwatt] from comment #56)
> (In reply to Stephen Horlander [:shorlander] from comment #37)
> > If we want to properly support the Windows 10 color options we are probably
> > going to need to know the status of the following system prefs:
> > - Show color on titlebar
> > - Choose your app mode: Light | Dark
> 
> As far as I can tell the Light/Dark app mode does not affect the color that
> is used in the titlebar, so I don't think we need to worry about that. Or am
> I missing something?

Yeah, don't need to worry about Light | Dark mode since we have separate built in themes for that.

Comment 60

[Dão Gottwald [:dao]]

Attachment: Bug 1196266 - Use Windows 10 accent color in the title bar when in the foreground.

Review commit: https://reviewboard.mozilla.org/r/154248/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154248/

Comment 61

[Johann Hofmann [:johannh]]

Comment on attachment 8883360 [details]
Bug 1196266 - Use Windows 10 accent color in the title bar when in the foreground.

https://reviewboard.mozilla.org/r/154248/#review159756

Coloring the titlebar mostly works for me with this patch (yay), but I need to restart the browser for it to pick up the general "Show accent color on the following surfaces: Title bars" checkbox change and there are some other hickups around live-switching these settings while Firefox is open. I think they're all platform issues that I need to check with jwatt, so the r- is just because of the comment below.

::: browser/themes/windows/browser-aero.css:53
(Diff revision 1)
>    }
>  
>    @media not all and (-moz-os-version: windows-win7) {
>      @media not all and (-moz-os-version: windows-win8) {
>        @media (-moz-windows-default-theme) {
> -        :root:not(:-moz-lwtheme) {
> +        :root:not(:-moz-window-inactive):not(:-moz-lwtheme) {

I'm fine with this change as part of Photon since I know that the new Photon tabs will probably look fine in inactive windows (at least now we know we should check for that), but it looks weird for Australis tabs. Please put this behind MOZ_PHOTON_THEME.

Comment 62

[Dão Gottwald [:dao]]

Comment on attachment 8883360 [details]
Bug 1196266 - Use Windows 10 accent color in the title bar when in the foreground.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/154248/diff/1-2/

Comment 63

[Dão Gottwald [:dao]]

Comment on attachment 8883360 [details]
Bug 1196266 - Use Windows 10 accent color in the title bar when in the foreground.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/154248/diff/2-3/

Comment 64

[Johann Hofmann [:johannh]]

Comment on attachment 8883360 [details]
Bug 1196266 - Use Windows 10 accent color in the title bar when in the foreground.

https://reviewboard.mozilla.org/r/154248/#review159854

Looks good, thanks!

Comment 65

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df0fff1d1e83
Use Windows 10 accent color in the title bar when in the foreground. r=johannh

Comment 66

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/df0fff1d1e83

Comment 67

[Ionuț Goldan [:igoldan]]

This added in some Windows 10 improvements:

== Change summary for alert #7730 (as of July 06 2017 12:05 UTC) ==

Improvements:

 16%  sessionrestore_many_windows windows10-64 opt e10s     4,406.83 -> 3,710.17

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=7730

Comment 68

[Brindusa Tot, Desktop QA]

Verified As fixed on latest Nightly 57.0a1, on Windows 10. Marking it verified as fixed.

Comment 69

[no]

Is there a way to disable this? It's too distracting, especially as you *have* content (your tabs) in the title bar, unlike practically everything else

Comment 70

[Stephen Horlander [:shorlander]]

(In reply to no from comment #69)
> Is there a way to disable this? It's too distracting, especially as you
> *have* content (your tabs) in the title bar, unlike practically everything
> else

Choosing the Light or Dark theme in Customize mode will over ride this setting.

Comment 71

[no]

In reply to Stephen Horlander [:shorlander] from comment #70)
> Choosing the Light or Dark theme in Customize mode will over ride this
> setting.

Is the only difference between the Default and Light theme the accent colour in the title bar?

I'd say this shouldn't be in the default theme. Edge is sane and doesn't mess around with accent colours, and at least with Chrome, non active tabs are decently opaque enough that they're not exactly the same colour as the rest of the title bar - which is important, considering how contrasting the accent colours normally are.

Comment 72

[Adolfo Jayme]

@[e-mail], this is not open for discussion. If I set an accent color (by default, Windows 10 windows are white), I expect all my software to follow MY CHOICE of accent color.

Comment 73

[no]

(In reply to Adolfo Jayme from comment #72)
> this is not open for discussion.

I don't see why it wouldn't be. It's been non-accented for the past two years. The difference between this and practically every other app is that they don't stick primary content into the title bar; having tabs the same colour as the accent colour is a mistake.

Comment 74

[Poopooracoocoo]

oofie this just became relevant again unless im missing something :((((

Comment 75

[eweitenberg]

Attachment: Screenshot of titlebars of Total Commander (left) and Firefox 89.0 (right)

To me it seems broken as well. For reference, I've attached a screenshot: on the left is an app that takes Windows' system title bar color (as per user setting), and on the right is Firefox in "System Theme", which is described to follow the system theme but does not have the system title bar color. It currently seems to be the same color as seen in the "Light Theme".

Given its description of "Follows the operating system for (...) windows", I would expect the Firefox System Theme title bar to match that of the unthemed app.

Comment 76

[Ryan Crellin]

(In reply to eweitenberg from comment #75)

Given its description of "Follows the operating system for (...) windows", I would expect the Firefox System Theme title bar to match that of the unthemed app.

Design differences aside (which is what I think Proton's change is, ultimately), I very much suspect the "system" theme is just an alias for "automatic" (meaning light/dark depending on system app mode). This in contrast to specific light/dark modes for example which would effectively force those modes instead of whatever the OS is trying to use.

Comment 77

[marczellm]

I believe some of you might be interested in a userChrome based solution. Unfortunately you have to hardcode your accent color, since the -moz-win-accentcolor value does not seem to be supported any more.

@-moz-document url(chrome://browser/content/browser.xhtml) {
    #TabsToolbar {
	    background: #ffb900;
    }

    #TabsToolbar:-moz-window-inactive {
	    background: inherit;
    }
}

Comment 78

[TomK]

This isn't fixed. While FF91 did honor the Windows color selection, FF92 again ignores it.

Comment 79

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to TomK from comment #78)

This isn't fixed. While FF91 did honor the Windows color selection, FF92 again ignores it.

@Dao, did we change anything here intentionally for Firefox 92?

Comment 80

[Masatoshi Kimura [:emk]]

Firefox 92 removed non-Proton code path for the title bar color. I guess bug 1722586.

Comment 81

[Dão Gottwald [:dao]]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #79)

(In reply to TomK from comment #78)

This isn't fixed. While FF91 did honor the Windows color selection, FF92 again ignores it.

@Dao, did we change anything here intentionally for Firefox 92?

Not that I know, other than proton changes that I wasn't directly involved with. Proton did break this on purpose, did it not? I personally think that was a step backwards but again I wasn't involved with that.

Comment 82

[Jared Wein [:jaws] (please needinfo? me)]

Yes, Proton changed the expectation here but that was in Firefox 89, so it was surprising to see comment 78. @TomK, did you have Proton disabled via prefs?

Comment 83

[TomK]

Proton is enabled.

See the attached screenshots

firefox-92.png shows Firefox after the upgrade (and the proton settings) and notepad-titlebar.png with notepad.exe showing the configured title bar color.

Putting the following into userChrome.css fixes this (again)

.titlebar-color {
  color: -moz-accent-color-foreground;
  background-color: -moz-accent-color;
}

Why do I have to mess around with userChrome after every upgrade to get a sensible UI back?

Comment 84

[TomK]

Attachment: firefox-92.png

Comment 85

[TomK]

Attachment: notepad-titlebar.png