Closed
Bug 1196287
Opened 9 years ago
Closed 9 years ago
remove the useless print_logcat function
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(firefox43 affected)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | affected |
People
(Reporter: parkouss, Assigned: parkouss)
References
Details
Attachments
(1 file)
|
3.57 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
In run_tests.py we have a function "print_logcat" that seems useless now. I think everything related to logcat.log should be removed in the same time.
|
Assignee | |
Comment 1•9 years ago
|
||
Oh, bug 1048836 would go away if we fix that I think.
See Also: → 1048836
|
|
Assignee | |
Comment 2•9 years ago
|
||
Should be applied on top of the patch in bug 1195288.
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8650062 [details] [diff] [review] 1196287.patch Review of attachment 8650062 [details] [diff] [review]: ----------------------------------------------------------------- I think there are a few other print_logcat spots in run_tests.py :)
Attachment #8650062 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
I did a grep on py files and did not see any (please tell me if I missed something!) Pushed to try on the existing push (will be the second jobs): https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4f3d39d4615
|
|
Assignee | |
Comment 5•9 years ago
|
||
All green, so I think we are good! Landed in https://hg.mozilla.org/build/talos/rev/3625fcaa75ea.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•