Closed
Bug 1196414
Opened 9 years ago
Closed 9 years ago
[Music][NGA] Add missing overlay dialogs
Categories
(Firefox OS Graveyard :: Gaia::Music, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
FxOS-S6 (04Sep)
People
(Reporter: justindarc, Assigned: justindarc)
References
Details
Attachments
(2 files)
The Music NGA app needs to display "overlay" dialogs for various statuses such as "No Music", etc.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jdarcangelo
Target Milestone: --- → FxOS-S6 (04Sep)
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8650871 [details] [review] [gaia] justindarc:bug1196414 > mozilla-b2g:master This patch also integrates your most recent changes to db.js from Music OGA.
Attachment #8650871 -
Flags: review?(squibblyflabbetydoo)
Comment 3•9 years ago
|
||
Comment on attachment 8650871 [details] [review] [gaia] justindarc:bug1196414 > mozilla-b2g:master This looks good, but r- because I think you're being a little too conservative in not changing db.js's code. A lot of its contents were just placeholders until we rewrote the app.
Attachment #8650871 -
Flags: review?(squibblyflabbetydoo) → review-
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8650871 [details] [review] [gaia] justindarc:bug1196414 > mozilla-b2g:master Edited db.js to no longer be dependent upon `App` global and it now directly broadcasts `service` events and internally waits for `ready` and `enumerable` promises to resolve before allowing DB operations to continue.
Attachment #8650871 -
Flags: review- → review?(squibblyflabbetydoo)
Comment 5•9 years ago
|
||
Comment on attachment 8650871 [details] [review] [gaia] justindarc:bug1196414 > mozilla-b2g:master Land it!
Attachment #8650871 -
Flags: review?(squibblyflabbetydoo) → review+
Assignee | ||
Comment 6•9 years ago
|
||
Landed on master: https://github.com/mozilla-b2g/gaia/commit/c74e69d85e0f6a18afe3fa27a8eeceae70a2ff18
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 7•9 years ago
|
||
Backed out along with bug 1196425. https://github.com/mozilla-b2g/gaia/commit/e95a7f36fbaac719d218691a08f5333bc0988337
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 8•9 years ago
|
||
Assignee | ||
Comment 9•9 years ago
|
||
Comment on attachment 8655100 [details] [review] [gaia] justindarc:bug1196414-v2 > mozilla-b2g:master Carrying over R+
Attachment #8655100 -
Flags: review+
Assignee | ||
Comment 10•9 years ago
|
||
Landed on master: https://github.com/mozilla-b2g/gaia/commit/3f53a3aebf6d0fc4538d7f1e1f0bab0a07eccc89
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•