1197010 - [WebSMS] Android backend for createMessageCursor/createThreadCursor

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Comment 1

[Reuben Morais [:reuben]]

Attachment: Implement thread/message cursor API on Android

This patch:
- Moves all the WebSMS related native functions to use GeneratedNatives (SmsManager.h/cpp)
- Adapts the existing message list implementation in GeckoSmsManager to implement message cursors instead, and removes the old message list API
- Implements thread cursors

The SMS app successfully reads inbox threads and messages, but everything is read only so far (need to deal with whether we're the default SMS app or not in other bugs).

Missing things:
- widget/android/ is probably not the best place for SmsManager.h/cpp to live. Will move it to dom/mobilemessage/android.
- We start the SmsIoThread in a static code block in SmsManager.java, but it looks like that only runs when we first access the SmsManager class, so there's a race between initialization of the IO thread and the first Runnable to be posted. This needs to be fixed.

:snorp, do you see any obvious red flags here?

Comment 2

[Reuben Morais [:reuben]]

Oh, and this probably won't build without MOZ_WEBSMS_BACKEND, but that's just because I was trying to avoid a clobber, it's a trivial fix.

Comment 3

[Reuben Morais [:reuben]]

Attachment: Implement thread/message cursor API on Android

This fixes the race by using a HandlerThread and moves the code to dom/mobilemessage/android.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/3f9ca060b8d0

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for android build failures: https://treeherder.mozilla.org/logviewer.html#?job_id=2962406&repo=b2g-inbound

https://hg.mozilla.org/integration/b2g-inbound/rev/40c5046a6651

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/92a91d520488

Comment 7

[Reuben Morais [:reuben]]

…I was running |make update-generated-wrappers| on the wrong objdir :/

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/92a91d520488