Closed Bug 1197233 Opened 9 years ago Closed 9 years ago

When fullscreening a video while the dynamic toolbar is showing, the toolbar area shows garbage

Categories

(Firefox for Android Graveyard :: Toolbar, defect)

All
Android
defect
Not set
normal

Tracking

(firefox43 fixed)

RESOLVED FIXED
Firefox 43
Tracking Status
firefox43 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

Using the test case from bug 1196172, if you fullscreen the video while the toolbar is visible the top area of the screen shows garbage/underlying content. This is in addition to the content that is visible as part of that bug. The hit-testing also seems to be a bit off in that while fullscreened in this state taps on the scrubber and controller buttons are offset. All of this is a regression from the new dynamic toolbar and so I want to track it separately from bug 1196172, and fix this before I tackle that.
Attached patch PatchSplinter Review
The main problem was that DynamicToolbarAnimator.getViewportSize was getting called around the start of the animation so mToolbarTranslation was not what the final value would have been at the end of the animation.
Attachment #8651111 - Flags: review?(rbarker)
Attachment #8651111 - Flags: review?(rbarker) → review+
https://hg.mozilla.org/mozilla-central/rev/0d8e63323117
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: