1197404 - Webrtc overrides Alt-D during call for Tabs sharing devices in menu bar

Status: RESOLVED WORKSFORME

(Firefox :: Site Permissions, defect, P3)

Description

[Padraic Harley [:thelodger]]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150819100530

Steps to reproduce:

* Use Firefox 40 on Ubuntu 15.04
* Open Hello and start a chat
* Press Alt + D
 


Actual results:

* Firefox selects the newly added "Tabs sharing devices"

After closing Hello:

* Using Alt + D to select the Address Bar does not always work and nothing happens


Expected results:

* Firefox selects the Address Bar

After closing Hello:

* Firefox selects the Address Bar

Comment 1

[Padraic Harley [:thelodger]]

Default menu bar shortcut chars are "f, e, v, s, b, t, h".
Alternate options for the "Tabs sharing devices" Alt + '' shortcut char are "i, r, g, c, n", at least ones that I can't see doing anything atm.

If one of those could be used, that would be super! =D

Comment 2

[:shell escalante]

is there a way to find a free letter?

Comment 3

[Sevaan Franks [:sevaan]]

Hey David, would you be able to help here?

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Hi! Does this wiki page help?
https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-tasks-quickly

Please needinfo me again if that doesn't provide a solution for you.

Comment 5

[Padraic Harley [:thelodger]]

Hi folks,

I was just on a chat on https://meet.jit.si/ and noticed the same problem after giving audiovisual permissions to Jitsi. I think this should be moved to wherever the audiovisual api hooks are in Firefox. Any idea where that is?

Comment 6

[Padraic Harley [:thelodger]]

Hi folks,

Have been using https://appear.in/ (use ALL the WebRTC services) for chat with work colleagues for the last week and the same problem happens on my work laptop (Firefox 42 on Ubuntu 14.04).

Alt-D hasn't returned to the task of focussing the Address Bar after being used for "Tabs sharing devices" with two other services so I'm confident now that isn't a Hello-specific bug.

The only way I've found to remedy is to restart Firefox. Any suggestions on where this bug should be moved to would be great as I can't tell if this falls under Loop post-pivot.

Needinfo-ing Mark as he was the last to edit the bug =)

Comment 7

[Mark Banner (:standard8)]

If this is happening outside the conversation window, this seems like more of a Firefox bug. Moving to the right place. 

I think Florian should be able to point people to the right bit of code.

Comment 8

[Florian Quèze [:florian]]

The menu is created the first time it is used at http://mxr.mozilla.org/mozilla-central/source/browser/modules/webrtcUI.jsm?rev=2524d0d7a041#763
When it's no longer in use, it's hidden (not removed), at http://mxr.mozilla.org/mozilla-central/source/browser/modules/webrtcUI.jsm?rev=2524d0d7a041#832 which probably explains why the accesskey still goes to it (I'm somewhat surprised a hidden menu prevents the accesskey from focusing something else that's visible).

As a workaround, Command+L should work to focus the address bar.

Comment 9

[Padraic Harley [:thelodger]]

Thanks for the replies folks!

I've been using ctrl+L here since Florian suggested it and it works perfectly, even if it plays heck with my muscle memory =P

Comment 10

[Mark Banner (:standard8)]

Support for Hello/Loop has been discontinued.

https://support.mozilla.org/kb/hello-status

Hence closing the old bugs. Thank you for your support.

Comment 11

[Simon Lindholm]

This is not just related to Hello, reopening. (On behalf of a friend, for whom this is a major gripe with Firefox.)

Alt+G seems like a reasonable shortcut?

Comment 12

[Randell Jesup [:jesup] (needinfo me)]

Tried in Fedora 25, Nightly.  In a call, Alt-D selects the addressbar data.  (Ctrl-L works too)  Also works while sharing a screen in appear.in, and with gum_test while sharing windows, etc.