Closed Bug 1197592 Opened 9 years ago Closed 9 years ago

APZAllowZooming pref is not consistently applied

Categories

(Core :: Panning and Zooming, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
In bug 1186004 I added an apz.allow_zooming pref and in bug 1187792 I made it so that the SPCSPS was not set on platforms where apz.allow_zooming is false. However I only guarded the callsite in APZCCallbackHelper and not the callsite in MobileViewportManager which I now think should be guarded as well. In particular, I want this to make the tests pass with the rest of my fixes for bug 1180267.
Attached patch PatchSplinter Review
Try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=df560bf8cef6 includes this patch.
Attachment #8651505 - Attachment is obsolete: true
Attachment #8651750 - Flags: review?(botond)
Attachment #8651750 - Flags: review?(botond) → review+
https://hg.mozilla.org/mozilla-central/rev/44ffa68bc9d7
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: