Closed Bug 119764 Opened 23 years ago Closed 22 years ago

javascript strict warnings in pref-themes.js

Categories

(SeaMonkey :: Preferences, defect)

Product:
SeaMonkey
Component:
Preferences
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Future

People

(Reporter: bugzilla, Assigned: stdowa+bugzilla)

Details

(Keywords: helpwanted)

Attachments

(1 file, 1 obsolete file)

patch v1.1
833 bytes, patch
Morten
: review+
hewitt
: superreview+
Details | Diff | Splinter Review 
Warning: reference to undefined property gData.loaded
Source File: chrome://communicator/content/pref/pref-themes.js
Line: 58

to reproduce:
just go into Edit -> Prefs -> Apperance -> Themes

build 20020111
Keywords: helpwanted
Target Milestone: --- → Future
Warning: reference to undefined property gData.loaded
Source File: chrome://communicator/content/pref/pref-themes.js
Line: 58
Warning: reference to undefined property gData.themeIndex
Source File: chrome://communicator/content/pref/pref-themes.js
Line: 59
20020116
Attached patch patch (obsolete) — — Splinter Review 

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch v1.1
        — 
          — Splinter Review
      

    


  

        Attachment #80299 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 81100 [details] [diff] [review]
patch v1.1

looks good
r=morten@nilsen.com

        Attachment #81100 -
        Flags: review+

    
    

    
  
Comment on attachment 81100 [details] [diff] [review]
patch v1.1

sr=hewitt

        Attachment #81100 -
        Flags: superreview+

    
    

    
  
when I click the themes item in Edit -> Prefs I also see:

Error: uncaught exception: 
[Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) 
[nsIXULChromeRegistry.isSkinSelected]"  nsresult: "0x80004003 
(NS_ERROR_INVALID_POINTER)"  location: "JS frame :: 
chrome://communicator/content/pref/pref-themes.js :: Startup :: line 76"  data: no]

not 
sure if it's outside the scope of this bug?

    
    

    
  
Henrik, that exception should be fixed when the skin in use is actually 
selected, bug 132242.
Assignee: sgehani → walk84

    
    

    
  
C:\moz_src\mozilla\xpfe\components\prefwindow\resources\content>cvs commit -
m "Bug 119764.  JS strict warnings in pref-themes.js.  Patch by Stephen Walker 
<walk84@yahoo.com> r=morten@nilsen.com/sr=hewitt@netsca
pe.com" pref-themes.js
Checking in pref-themes.js;
/cvsroot/mozilla/xpfe/components/prefwindow/resources/content/pref-themes.js,v  
<--  pref-themes.js
new revision: 1.33; previous revision: 1.32
done
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED

    
    

    
  
other than what still occurs in comment 6 (covered by bug 132242), i don't see
the strict warnings orginally reported. vrfy'd fixed using 2002.06.17.08 comm
trunk bits on linux rh7.2.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: