1197680 - Remembering credentials while the "Saved Passwords" window is open can cause temporary a wrong ordering

Status: RESOLVED DUPLICATE of bug 211352

(Toolkit :: Password Manager, defect)

Description

[sworddragon2]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150820085905



Actual results:

After going to the "Saved Passwords" window to copy the username/password from there into a https version of the related site and remembering the new credentials I have noticed that the ordering in the "Saved Passwords" window broke until it got opened again.


Expected results:

Remembering new credentials while the "Saved Passwords" window is open should correctly sort it.

Comment 1

[Justin [:JW_SoftvisionQA]]

Hello,

I understand exactly what you are saying here but could you provide me with exact links to sites so that I can see exactly what you are seeing?

Thank you,

Justin

Comment 2

[sworddragon2]

This should work with any site that provides a http and https version.

Comment 3

[YF (Yang)]

I don't understand this bug, can you explain it?

Comment 4

[sworddragon2]

In about:preferences#security open the "Saved Logins" dialog and while it is open migrate manually a login from http to https by visiting a website. After selecting to remember your credentials the ordering of the still opened "Saved Logins" dialog temporary break.

Comment 5

[Justin [:JW_SoftvisionQA]]

What do you mean by (In reply to sworddragon2 from comment #4)
> After selecting to remember your credentials the ordering of the still
> opened "Saved Logins" dialog temporary break.

The new password was and user name combination was added and the dialog was still functional.

Comment 6

[sworddragon2]

Steps to reproduce:

1. Start Firefox and go to about:preferences#security.
2. Click on "Saved Logins..." and sort by "Username" (ascending).
3. Search for "https://bugzilla.mozilla.org".
4. Go to https://bugzilla.mozilla.org.
5. Login as testb with any password.
6. Click on "Remember" to store the credentials.
7. Login as testa with any password.
8. Click on "Remember" to store the credentials.


Actual results:

testb is sorted before testa.


Expected results:

testb should be sorted after testa.

Comment 7

[Justin [:JW_SoftvisionQA]]

When adding a new password it sorts by url. (In reply to sworddragon2 from comment #6)
> Steps to reproduce:
> 
> 1. Start Firefox and go to about:preferences#security.
> 2. Click on "Saved Logins..." and sort by "Username" (ascending).
> 3. Search for "https://bugzilla.mozilla.org".
> 4. Go to https://bugzilla.mozilla.org.
> 5. Login as testb with any password.
> 6. Click on "Remember" to store the credentials.
> 7. Login as testa with any password.
> 8. Click on "Remember" to store the credentials.
> 
> 
> Actual results:
> 
> testb is sorted before testa.
> 
> 
> Expected results:
> 
> testb should be sorted after testa.

Since testb was added first, it has precedence over testa. You can how ever manually sort by username which would then appropriately sort it to your liking.

Comment 8

[sworddragon2]

(In reply to Justin - QA from comment #7)
> When adding a new password it sorts by url.

This is not the case here. Adding a new password still does sort by Username as previously selected. This also means that the sorting is wrong with testb being before testa.

Comment 9

[Justin [:JW_SoftvisionQA]]

I can not reproduce this issue as my sort for username places testa before testb when selecting sort by username before adding test a on Nightly 46.0a1 or Firefox 40.0.

1. Please try testing with a clean profile https://support.mozilla.org/en-US/kb/refresh-firefox-reset-add-ons-and-settings 

2. Please try testing with your addons disabled https://support.mozilla.org/en-US/kb/disable-or-remove-add-ons

Comment 10

[sworddragon2]

(In reply to Justin - QA from comment #9)
> I can not reproduce this issue as my sort for username places testa before
> testb when selecting sort by username before adding test a on Nightly 46.0a1
> or Firefox 40.0.

Do you have sorted by Username before adding any of testa and testb and also added testb before testa? If not you maybe want to make a look again at the reproduction steps.

Comment 11

[Justin [:JW_SoftvisionQA]]

Here is the screencast of my testing. Please inform me if I did any steps wrong.

http://www.screencast.com/t/PnmwZp8QBNst

Comment 12

[sworddragon2]

Step 3 was missing but since you had no logins in this test you have possibly skipped it for this reason. But besides from this it looked correct and the bug did indeed not trigger in your case. I have now tested what happens if I reproduce this issue by ignoring step 3 too (even with my normal profile that contains several credentials): The bug did then not appear for me too. Maybe this bug was then triggered because searching for "https://bugzilla.mozilla.org" returned already my normal login.

Comment 13

[Mike Hoye [:mhoye]]

Sworddragon2 - do we still believe we have a bug here? There might be something here, but I'm inclined to say that unless we can successfully reduce this to a minimal testcase or demonstrate some underlying pathology in our list sorting, that we won't be able to act on this.

Comment 14

[sworddragon2]

The bug seems to have a special condition but I can't tell what it is. Maybe somebody else is able to reproduce this issue or to provide more stable reproduction steps.

Comment 15

[Justin [:JW_SoftvisionQA]]

set the proper component so that a dev can take a look at this.

Comment 16

[Matthew N. [:MattN]]

I agree this is a bug.