Closed
Bug 1197699
Opened 9 years ago
Closed 9 years ago
always store the ip address in the logincookies table
Categories
(bugzilla.mozilla.org :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: glob, Assigned: glob)
References
Details
Attachments
(1 file)
|
3.77 KB,
patch
|
dylan
:
review+
|
Details | Diff | Splinter Review |
we should always store the ip address in the logincookies table, and have a separate column restrict_ip_address or something similar to know if the login cookie must be restricted to this IP address or not.
Attachment #8651657 -
Flags: review?(dylan)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8651657 [details] [diff] [review] 1197699_1.patch Review of attachment 8651657 [details] [diff] [review]: ----------------------------------------------------------------- r=dylan
Attachment #8651657 -
Flags: review?(dylan) → review+
schema only: To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git 57f911c..24e4c03 master -> master
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git 85adb94..90a6182 master -> master
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Comment 5•9 years ago
|
||
It's a pity this patch hasn't been proposed upstream as it's also requested there, see bug 1060970. Unless your patch is a hack, which doesn't seem to be the case, could you attach it there too, please? No need to do the work twice if the patch already exists.
You need to log in
before you can comment on or make changes to this bug.
Description
•