Closed
Bug 1197874
Opened 9 years ago
Closed 9 years ago
Remove MatchstickApp.jsm from the build
Categories
(Firefox Build System :: Android Studio and Gradle Integration, defect)
Firefox Build System
Android Studio and Gradle Integration
All
Android
Tracking
(firefox43 fixed)
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: rnewman, Assigned: anirudh24seven, Mentored)
References
Details
(Whiteboard: [good-first-bug][lang=js])
Attachments
(1 file)
14.55 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Matchstick isn't going to ship, right? If we don't have any other consumers for this code, we should save the kilobytes.
Updated•9 years ago
|
Mentor: mark.finkle
Whiteboard: [good-first-bug][lang=js]
Assignee | ||
Comment 1•9 years ago
|
||
Reporter | ||
Updated•9 years ago
|
Attachment #8659283 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 2•9 years ago
|
||
I have removed all references to Matchstick. This should be enough, right?
Flags: needinfo?(mark.finkle)
Comment 3•9 years ago
|
||
Comment on attachment 8659283 [details] [diff] [review] Remove MatchstickApp.jsm from the build Yes. Looks good.
Flags: needinfo?(mark.finkle)
Attachment #8659283 -
Flags: review?(mark.finkle) → review+
Updated•9 years ago
|
Assignee: nobody → anirudh24seven
Reporter | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Reporter | ||
Comment 4•9 years ago
|
||
Anirudh: could you push this to Try before setting checkin-needed? https://wiki.mozilla.org/ReleaseEngineering/TryServer
Assignee | ||
Comment 5•9 years ago
|
||
Richard: Sure. Will do so. I would require someone to vouch for my Level 1 Commit Access though. https://bugzilla.mozilla.org/show_bug.cgi?id=1204188
Flags: needinfo?(rnewman)
Assignee | ||
Comment 7•9 years ago
|
||
I pushed it to Try and it completed successfully. https://treeherder.mozilla.org/#/jobs?repo=try&revision=29fe2bcd7ff6
Flags: needinfo?(rnewman)
Keywords: checkin-needed
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d9824a8871c8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Reporter | ||
Updated•8 years ago
|
Flags: needinfo?(rnewman)
Updated•5 years ago
|
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 43 → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•