Closed Bug 1197948 Opened 9 years ago Closed 9 years ago

Playback test sometimes times out too soon when YouTube video has ad at the beginning or mid-way

Categories

(Testing Graveyard :: external-media-tests, defect)

Product:
Testing Graveyard
Component:
external-media-tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: impossibus, Assigned: impossibus)

References

Details

Attachments

(1 file)

GitHub pull request
53 bytes, text/x-github-pull-request
sydpolk
: review+
Details | Review 
In short, the problem is that |current_time| and |duration| reported by YouTube refer to whatever stream is playing right now, and that stream might be an ad, not the main video.
Attachment #8651929 - Flags: review? → review?(spolk)
I have some questions put into the pull request. Please answer those. I don't anticipate any code changes coming out of them, so leaving the review flag along for now.
Flags: needinfo?(mjzffr)
Flags: needinfo?(mjzffr)
Attachment #8651929 - Flags: review?(spolk) → review+
Looks good. Please merge. Thanks.
https://github.com/mjzffr/firefox-media-tests/commit/de8f41546d7fbd5191349b1290f1930fb2d7a297

Also added back the video that caused us to notice the early-timeout problem:
https://github.com/mjzffr/firefox-media-tests/commit/b738fa6a1f539faef0509a5a059aa01c25865b64

Deployed to pf-jenkins branch.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: