1198127 - Garbage collection markers should be real markers

Status: RESOLVED WONTFIX

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

Description

[Victor Porof [:vporof][:vp]]

Right now they're faked on the js land in timeline.js. I don't see a real reason why this is the case, and makes my marker data compacting efforts a bit harder.

Comment 1

[Victor Porof [:vporof][:vp]]

Y DIS UNREAL?

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Because its from Debugger.Memory is my understanding

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

The onGarbageCollection hook has dual purposes: first, it provides a sense of time for the allocations log, and second we can use it to create GC markers. It would be fine to use AutoTimelineMarker or whatever for the second purpose and have the onGarbageCollection hook only for the first. It would require a TimelineMarker subclass to attach the gc reason and whether it is non-incremental or not. Also the gc number, after bug 1197970. I think this is possible from inside SpiderMonkey, but I always forget how the interactions with the profiler work from inside the engine.

Comment 4

[Victor Porof [:vporof][:vp]]

Markers can be created whenever now, lazily, as long as we have timestamps. We're not forced to create them exactly where the marked code in question is being executed.

Comment 5

[Victor Porof [:vporof][:vp]]

Triaging. Filter on ADRENOCORTICOTROPIC (yes).

Comment 6

[Julien Wajsberg [:julienw]]

Now that we replaced the old performance panel by the Firefox Profiler (see Bug 1668219) we're closing bugs related to this.

Filter on MASSCLOSEOLDPERFTOOLBUGS.