1198192 - [Music][NGA] Improve performance of Home view

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Music, defect)

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] wilsonpage:1198192 > mozilla-b2g:master

Comment 2

[Wilson Page [:wilsonpage]]

Comment on attachment 8652257 [details] [review]
[gaia] wilsonpage:1198192 > mozilla-b2g:master

Based on top of bug 1196414

Comment 3

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8652257 [details] [review]
[gaia] wilsonpage:1198192 > mozilla-b2g:master

Left some comments on the PR, mostly regarding coding style and maintaining consistency. Please address them before landing. Overall, this patch looks ok.

Comment 4

[Wilson Page [:wilsonpage]]

Addressed comments and waiting for green.

Comment 5

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/5dfcd9deb2fcdab894ee9cae2d31da9bac732df5

Comment 6

[Justin D'Arcangelo [:justindarc]]

Looks like there was a merge failure here. Fixing in Bug 1203212.

Comment 7

[Justin D'Arcangelo [:justindarc]]

Carsten:

It looks like there were some git merge failures, possibly from rebasing. This patch needs backed out ASAP. It is causing Gij test failures along with some other issues.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Reverted in https://github.com/mozilla-b2g/gaia/commit/e8620fa6aee9c98ad0e9124828789ab37f6e50fe

Comment 9

[Wilson Page [:wilsonpage]]

Apologies for the time wasting. A last minute merge conflict broke the js/view.js module. Fixed and pushed. I'm not really sure why it was landed if there were test failures.

Comment 10

[Hubert Figuiere [:hub]]

I think the test failure looked a lot like an intermittent orange we have seen, hence were wrongfully ignored. Not certain though.

Comment 11

[Wilson Page [:wilsonpage]]

Comment on attachment 8652257 [details] [review]
[gaia] wilsonpage:1198192 > mozilla-b2g:master

- Decreased default album artwork jpg compression
- Restored scroll position to hide <music-search> and prevent it from blocking the list content from receiving 'click's (probably a bug).

Comment 12

[Wilson Page [:wilsonpage]]

Justin is there anything blocking us from landing this?

Comment 13

[Justin D'Arcangelo [:justindarc]]

(In reply to Wilson Page [:wilsonpage] from comment #12)
> Justin is there anything blocking us from landing this?

Let's wait until we're feature complete before we make any optimizations.

Comment 14

[Justin D'Arcangelo [:justindarc]]

I'm going to take this bug over to implement lazy album art retrieval for the Home (tiles) view. Also, most of the stuff in Wilson's patch has already landed in other patches, but some of the CSS related to the tiles in his patch still needs to land.

Comment 15

[Justin D'Arcangelo [:justindarc]]

(In reply to Justin D'Arcangelo [:justindarc] from comment #14)
> I'm going to take this bug over to implement lazy album art retrieval for
> the Home (tiles) view. Also, most of the stuff in Wilson's patch has already
> landed in other patches, but some of the CSS related to the tiles in his
> patch still needs to land.

It could either be that or maybe related to Bug 1209716 which is about an album art race condition.

Comment 16

[Justin D'Arcangelo [:justindarc]]

(In reply to Justin D'Arcangelo [:justindarc] from comment #15)
> (In reply to Justin D'Arcangelo [:justindarc] from comment #14)
> > I'm going to take this bug over to implement lazy album art retrieval for
> > the Home (tiles) view. Also, most of the stuff in Wilson's patch has already
> > landed in other patches, but some of the CSS related to the tiles in his
> > patch still needs to land.
> 
> It could either be that or maybe related to Bug 1209716 which is about an
> album art race condition.

Disregard this. Comment intended for another bug.

Comment 17

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8652257 [details] [review]
[gaia] wilsonpage:1198192 > mozilla-b2g:master

Clearing r? flag. I believe we have landed other optimizations to the Home view already that render this patch obsolete.

Comment 18

[Justin D'Arcangelo [:justindarc]]

Not working on this. Unassigning myself.

Comment 19

[BMO Automation]

Firefox OS is not being worked on