Closed
Bug 1198364
Opened 9 years ago
Closed 9 years ago
test_TelemetrySend.js, test_TelemetryReportingPolicy.js test failures if FHR upload pref not set
Categories
(Toolkit :: Telemetry, defect)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla43
People
(Reporter: aleth, Assigned: aleth)
References
Details
Attachments
(1 file, 1 obsolete file)
1.32 KB,
patch
|
gfritzsche
:
review+
ritu
:
approval-mozilla-aurora+
ritu
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
The same pref issue as bug 1197612 also causes these test failures on c-c: TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_TelemetrySend.js | xpcshell return code: 0 TEST-UNEXPECTED-TIMEOUT | toolkit/components/telemetry/tests/unit/test_TelemetryReportingPolicy.js | Test timed out
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8652432 -
Flags: review?(gfritzsche)
Updated•9 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment 2•9 years ago
|
||
Comment on attachment 8652432 [details] [diff] [review] telemetrytests2.diff Review of attachment 8652432 [details] [diff] [review]: ----------------------------------------------------------------- I think before we start doing this across more individual tests we should check if we can just do this once here: https://dxr.mozilla.org/mozilla-central/rev/c46370eea81a9860ae77d1f0c7776c24e816138e/toolkit/components/telemetry/tests/unit/head.js#324
Attachment #8652432 -
Flags: review?(gfritzsche)
Assignee | ||
Comment 3•9 years ago
|
||
Good idea! Seems to work.
Attachment #8652432 -
Attachment is obsolete: true
Attachment #8652818 -
Flags: review?(gfritzsche)
Comment 4•9 years ago
|
||
Comment on attachment 8652818 [details] [diff] [review] telemetryhead.diff Review of attachment 8652818 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, this looks good to me - but we should definitely do a full try run before landing to avoid fallout on odd configurations etc.
Attachment #8652818 -
Flags: review?(gfritzsche) → review+
Assignee | ||
Comment 5•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=52e6c9fb33a3
Assignee | ||
Comment 6•9 years ago
|
||
(In reply to aleth [:aleth] from comment #5) > https://treeherder.mozilla.org/#/jobs?repo=try&revision=52e6c9fb33a3 Looks OK to me.
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b93c557d50b8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Comment 9•9 years ago
|
||
Comment on attachment 8652818 [details] [diff] [review] telemetryhead.diff Approval Request Comment [Feature/regressing bug #]: telemetry tests [User impact if declined]: comm tests fail [Describe test coverage new/current, TreeHerder]: works on c-c [Risks and why]: none expected, test only [String/UUID change made/needed]: none
Attachment #8652818 -
Flags: approval-mozilla-beta?
Attachment #8652818 -
Flags: approval-mozilla-aurora?
Comment on attachment 8652818 [details] [diff] [review] telemetryhead.diff Test only change. Aurora42+, Beta41+
Attachment #8652818 -
Flags: approval-mozilla-beta?
Attachment #8652818 -
Flags: approval-mozilla-beta+
Attachment #8652818 -
Flags: approval-mozilla-aurora?
Attachment #8652818 -
Flags: approval-mozilla-aurora+
status-firefox41:
--- → affected
status-firefox42:
--- → affected
Comment 11•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/3da0d30d73b0
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•