1198421 - "Welcome to ..." needs a bottom border on the standalone UI

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

This is a recent regression in the context improvements.

The "Welcome to ..." has no bottom padding if there's no context displayed on the standalone UI. As a result, it looks strange, and hence we need to fix it.

We need to be careful, as we can't just take the padding from the context element and put it on the room name, as the desktop UI needs it.

Comment 1

[Mark Banner (:standard8)]

Attachment: 'Welcome to ...' needs a bottom border on the Loop standalone UI.

This fixes it, though the additional css isn't really my favourite. Due to the need to have the top padding on desktop but not standalone, this seems the most reasonable way for it.

Mike, before I add tests, what do you think?

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8652486 [details] [diff] [review]
'Welcome to ...' needs a bottom border on the Loop standalone UI.

Review of attachment 8652486 [details] [diff] [review]:
-----------------------------------------------------------------

I can't think of better way. Go for it!

Comment 3

[Mark Banner (:standard8)]

Attachment: Screen shot of fix

Before is on the left, after in the middle, and the bits on the right are showing it with context for reference.

Comment 4

[Mark Banner (:standard8)]

Attachment: 'Welcome to ...' needs a bottom border on the Loop standalone UI.

Updated patch with unit tests, depends on tidy up in bug 1157646.

Comment 5

[Mike de Boer [:mikedeboer]]

Comment on attachment 8652812 [details] [diff] [review]
'Welcome to ...' needs a bottom border on the Loop standalone UI.

Review of attachment 8652812 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 6

[Sevaan Franks [:sevaan]]

Comment on attachment 8652796 [details]
Screen shot of fix

Looks great. Thanks, Mark!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/cdc4dc6af449

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cdc4dc6af449

Comment 9

[Bogdan Maris, Desktop QA]

Was unable to reproduce the initial behavior but I can confirm the updated bottom border in Standalone UI using latest Nightly 43.0a1 across platforms (Windows 7 64-bit, Mac OS X 10.10.5 and Ubuntu 14.04 32-bit).