1198726 - tooltool.py to be included in (gecko) docker build images

Status: RESOLVED FIXED

(Taskcluster :: Services, defect)

Description

[Pete Moore [:pmoore][:pete]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1198173#c23 for context.

Basically we should include tooltool.py in docker image rather than cloning git.mozilla.org / github.com for each task execution.

NB: if tooltool.py needs updating, we would now need to bump VERSION of docker images in-tree, and publish the new binaries to whichever registry/registries they can be downloaded from. A new tooltool.py won't get picked up automatically.

Comment 1

[Pete Moore [:pmoore][:pete]]

Also, we should try to avoid relying on github.com availability in tasks, where we have mirroring set up for git.mozilla.org, since it can place a strain on github.com that may cause them to block access.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

(In reply to Pete Moore [:pmoore][:pete] from comment #0)
> NB: if tooltool.py needs updating, we would now need to bump VERSION of
> docker images in-tree, and publish the new binaries to whichever
> registry/registries they can be downloaded from. A new tooltool.py won't get
> picked up automatically.

I believe strongly that this should be the default expectation for any tool used by the build process that is not installed via tooltool.  It's already the case for tc-vcs, git, Python, Node, etc.

Comment 3

[Pete Moore [:pmoore][:pete]]

Moving to TaskCluster component...

Comment 4

[Jonas Finnemann Jensen (:jonasfj)]

I'm pretty sure do this for most images in-tree:
https://dxr.mozilla.org/mozilla-central/rev/df0e967f8e8fa30a69338008b6ee296bf5e9c545/taskcluster/docker/desktop1604-test/Dockerfile#53

@pmoore, do you want to review all images, or can we close?

Comment 5

[Pete Moore [:pmoore][:pete]]

(In reply to Jonas Finnemann Jensen (:jonasfj) from comment #4)
> I'm pretty sure do this for most images in-tree:
> https://dxr.mozilla.org/mozilla-central/rev/
> df0e967f8e8fa30a69338008b6ee296bf5e9c545/taskcluster/docker/desktop1604-test/
> Dockerfile#53
> 
> @pmoore, do you want to review all images, or can we close?

Indeed, it looks like we do include it, and interestingly the canonical source is now in-tree[1] (rather than github) - which is also a plus.
--
[1] https://hg.mozilla.org/mozilla-central/file/a6a32fb286fa/python/mozbuild/mozbuild/action/tooltool.py