Closed
Bug 1198726
Opened 9 years ago
Closed 6 years ago
tooltool.py to be included in (gecko) docker build images
Categories
(Taskcluster :: Services, defect)
Taskcluster
Services
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pmoore, Unassigned)
References
Details
See https://bugzilla.mozilla.org/show_bug.cgi?id=1198173#c23 for context. Basically we should include tooltool.py in docker image rather than cloning git.mozilla.org / github.com for each task execution. NB: if tooltool.py needs updating, we would now need to bump VERSION of docker images in-tree, and publish the new binaries to whichever registry/registries they can be downloaded from. A new tooltool.py won't get picked up automatically.
Reporter | ||
Comment 1•9 years ago
|
||
Also, we should try to avoid relying on github.com availability in tasks, where we have mirroring set up for git.mozilla.org, since it can place a strain on github.com that may cause them to block access.
Comment 2•9 years ago
|
||
(In reply to Pete Moore [:pmoore][:pete] from comment #0) > NB: if tooltool.py needs updating, we would now need to bump VERSION of > docker images in-tree, and publish the new binaries to whichever > registry/registries they can be downloaded from. A new tooltool.py won't get > picked up automatically. I believe strongly that this should be the default expectation for any tool used by the build process that is not installed via tooltool. It's already the case for tc-vcs, git, Python, Node, etc.
Reporter | ||
Comment 3•8 years ago
|
||
Moving to TaskCluster component...
Component: TaskCluster → Integration
Product: Testing → Taskcluster
Updated•8 years ago
|
Component: Integration → Platform and Services
Comment 4•6 years ago
|
||
I'm pretty sure do this for most images in-tree: https://dxr.mozilla.org/mozilla-central/rev/df0e967f8e8fa30a69338008b6ee296bf5e9c545/taskcluster/docker/desktop1604-test/Dockerfile#53 @pmoore, do you want to review all images, or can we close?
Flags: needinfo?(pmoore)
Reporter | ||
Comment 5•6 years ago
|
||
(In reply to Jonas Finnemann Jensen (:jonasfj) from comment #4) > I'm pretty sure do this for most images in-tree: > https://dxr.mozilla.org/mozilla-central/rev/ > df0e967f8e8fa30a69338008b6ee296bf5e9c545/taskcluster/docker/desktop1604-test/ > Dockerfile#53 > > @pmoore, do you want to review all images, or can we close? Indeed, it looks like we do include it, and interestingly the canonical source is now in-tree[1] (rather than github) - which is also a plus. -- [1] https://hg.mozilla.org/mozilla-central/file/a6a32fb286fa/python/mozbuild/mozbuild/action/tooltool.py
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(pmoore)
Resolution: --- → FIXED
Assignee | ||
Updated•5 years ago
|
Component: Platform and Services → Services
You need to log in
before you can comment on or make changes to this bug.
Description
•