1199461 - Name for carrier / operator is not consistent

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Irina Sandu]

User-Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

We are using 2 different names for the same thing in the Cellular Settings menu. It's Carrier at the top and Network Operator further down. Let's be consistent. Network operator is probably a more universal term than carrier.

Comment 1

[Irina Sandu]

Attachment: system-b2g-application.ini

Comment 2

[Irina Sandu]

Attachment: dev-log-main.log

Comment 3

[Irina Sandu]

Attachment: properties.log

Comment 4

[Irina Sandu]

Attachment: screenshot.png

Comment 5

[Peter Dolanjski [:pdol]]

[Tracking Requested - why for this release]:

Let's stick with 'operator' which is the most universally accepted name.  I suggest changing carrier to operator.

Comment 6

[[e-mail]]

@harly could you help picking a proper name here?

Comment 7

[[e-mail]]

ni @matej for wording as well

Comment 8

[Matej Novak [:matej]]

(In reply to Fred Lin [:gasolin] from comment #7)
> ni @matej for wording as well

+1 to "Operator"

Comment 9

[Harly Hsu[:harly]]

I am fine with changing "Carrier" to "Operator". Thanks

Comment 10

[[e-mail]]

So this issue will change strings in `Settings > Cellular & Data` panel:

"Carrier" to "Operator" 

and

"Network Operator" to "Operator"

Comment 11

[Louie Lu]

Hello, I like to take this bug, 
can you assigned to me?

And a question, how can I test `Settings > Cellular` in web IDE that I didn't have a real device for SIM card?

thanks.

Comment 12

[[e-mail]]

Louie, thanks for interesting in take this issue. 

It will be more tricky to fix this issue when you don't have a device, so I suggest you start from another issue :/ 

Hope we can fix that contribution issue soon.

Comment 13

[GitHub Autolander Bot]

Attachment: [gaia] grapherd:callular-fix > mozilla-b2g:master

Comment 14

[Louie Lu]

Attachment: Bug 1199461 - Change to "Operator" in settings.en-US.properties

Comment 15

[[e-mail]]

Comment on attachment 8655503 [details] [review]
Bug 1199461 - Change to "Operator" in settings.en-US.properties

Thanks for providing the patch!

For strings we have to rename the identifier to the other, so the automation tool can scan the difference and provide the changed strings to l10n team.

Please address the comment in github and set review again.

Comment 16

[Louie Lu]

Attachment: Bug 1199461 - Change to "Operator" in settings.en-US.properties

Change l10n identifier in carrier.html and carrier_detail.html to suggestion, too.

If the name of `Carrier` change to `Operator`, shall the element name and other carrier change to operator too?

e.g. 
carrier.html -> operator.html
<element name="carrier" ...> -> <element name="operator" ...>
<ul class="carrier-info" ...> -> <ul class="operator-info" ...>

Comment 17

[Louie Lu]

Comment on attachment 8657406 [details] [review]
Bug 1199461 - Change to "Operator" in settings.en-US.properties

>https://github.com/mozilla-b2g/gaia/pull/31634

Comment 18

[[e-mail]]

I have no strong opinion about change the naming here. You could change it or left it as you prefer.

Comment 19

[[e-mail]]

Comment on attachment 8655503 [details] [review]
Bug 1199461 - Change to "Operator" in settings.en-US.properties

Thanks for providing pull request, 

There's a string that use `networkOperator` as value, please replace it as well and set review again.

Comment 20

[[e-mail]]

louie are you stilll interesting on solving this one? Or I can take care of it as well.

Comment 21

[Louie Lu]

Comment on attachment 8655503 [details] [review]
Bug 1199461 - Change to "Operator" in settings.en-US.properties

>https://github.com/mozilla-b2g/gaia/pull/31634

Comment 22

[[e-mail]]

Thanks for update! For quick review it looks fine to me.

Though I got sick today and will get a test device tomorrow to check if everything works fine on real device.

Comment 23

[GitHub Autolander Bot]

Attachment: [gaia] gasolin:callular-fix > mozilla-b2g:master

Comment 24

[[e-mail]]

Comment on attachment 8655503 [details] [review]
Bug 1199461 - Change to "Operator" in settings.en-US.properties

It looks fine to me, though there are some missing titles which are hard to find when you don't have device on hand. So I'll help add the rest.

Thank you Louie!

Comment 25

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/77dc0976a3834016df50a6eb767a4f5a135d3852

thanks!

Comment 26

[Francesco Lodolo [:flod]]

Please, for the future keep (In reply to Fred Lin [:gasolin] from comment #15)
> For strings we have to rename the identifier to the other, so the automation
> tool can scan the difference and provide the changed strings to l10n team.

Exactly, but you still changed 2 strings without using new IDs: availableOperators, operator-turnAutoSelectOff.

Any chance for a quick follow-up?

Comment 27

[[e-mail]]

thanks for address the issue

merged https://github.com/mozilla-b2g/gaia/commit/33e8cfe0bf5f32d2ce860086d52a4a9534643ed7