Closed
Bug 1199537
Opened 9 years ago
Closed 9 years ago
Change the color of the only button on the alert modal dialog to gray
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(b2g-master verified)
VERIFIED
FIXED
FxOS-S6 (04Sep)
Tracking | Status | |
---|---|---|
b2g-master | --- | verified |
People
(Reporter: lchang, Assigned: Fischer)
Details
(Whiteboard: [good first bug])
Attachments
(3 files)
As mentioned in Bug 1195602 Comment 11, the dialog with only one single button should use gray color according to the building blocks guideline [1]. The following is an easy way to trigger this kind of dialog: 1. turn on Airplane Mode 2. go to Settings -> Internet Sharing 3. turn on Wi-Fi Hotspot 4. then you'll see an alert dialog [1] https://developer.mozilla.org/en-US/Apps/Design/Firefox_OS_building_blocks/Dialog
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → fliu
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8655320 -
Flags: review?(im)
Comment 3•9 years ago
|
||
Comment on attachment 8655320 [details] [review] PR #31627 looks good to me. thanks.
Attachment #8655320 -
Flags: review?(im) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 4•9 years ago
|
||
Master: https://github.com/mozilla-b2g/gaia/commit/5bf800dbceb2b9651ca442a13aa2952739976da1
Status: NEW → RESOLVED
Closed: 9 years ago
status-b2g-master:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S6 (04Sep)
Comment 5•9 years ago
|
||
This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0. Actual results: The dialog with only a single OK button is grey color instead of blue. See attachment: verified_Aries KK_v2.5.png Reproduce rate: 0/10 Device: Flame KK 2.5 (Pass) Build ID 20150905150219 Gaia Revision 03be7d8918bed58c92a40bba211bbbc97a0e516a Gaia Date 2015-09-04 11:56:30 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/139446daedab3d00b9f0faba25e1e82191c8c8d1 Gecko Version 43.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150905.183746 Firmware Date Sat Sep 5 18:38:03 EDT 2015 Firmware Version v18D v4 Bootloader L1TC000118D0 Device: Aries KK 2.5 (Pass) Build ID 20150905112803 Gaia Revision 03be7d8918bed58c92a40bba211bbbc97a0e516a Gaia Date 2015-09-04 11:56:30 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/139446daedab3d00b9f0faba25e1e82191c8c8d1 Gecko Version 43.0a1 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20150905.105729 Firmware Date Sat Sep 5 10:57:37 UTC 2015 Bootloader s1
Comment 6•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•