1199568 - IonMonkey: MIPS32: Use generic memory address operations as more as possible

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine: JIT, defect)

Description

[hev [:hev]]

Mostly address calculate and memory access operations use generic code (addPtr, subPtr, loadPtr, sotrePtr) can help extract more shared code into mips-shared.

Comment 1

[hev [:hev]]

Attachment: Merge MacroAssemblerMIPSCompat into MacroAssemblerMIPS

Make more memory access operations can be replaced by macro operations.

Comment 2

[hev [:hev]]

Attachment: Use generic memory address operations as more as possible

Comment 3

[hev [:hev]]

Attachment: Use generic memory access operations in header

Comment 4

[hev [:hev]]

Comment on attachment 8653916 [details] [diff] [review]
Merge MacroAssemblerMIPSCompat into MacroAssemblerMIPS

Note: depends bug 1194139 part 3

Comment 5

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8653916 [details] [diff] [review]
Merge MacroAssemblerMIPSCompat into MacroAssemblerMIPS

Review of attachment 8653916 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, I will remove this review flag, as the MacroAssembler*Compat classes are going away and the following patch merge the two classes to rely on the generic part of the MacroAssembler (see Bug 996602).
I'll suggest you to add the asMasm instead of merging the classes.

Comment 6

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8653917 [details] [diff] [review]
Use generic memory address operations as more as possible

Review of attachment 8653917 [details] [diff] [review]:
-----------------------------------------------------------------

Use the asMasm() functions.  I know this is more verbose, but the goal of the asMasm() functions is to annotate every function which can legitimately be moved to the generic macro assembler.

::: js/src/jit/mips32/MacroAssembler-mips32.cpp
@@ +866,5 @@
>  void
>  MacroAssemblerMIPS::ma_pop(Register r)
>  {
> +    loadPtr(Address(StackPointer, 0), r);
> +    addPtr(Imm32(sizeof(intptr_t)), StackPointer);

Do not make a ma_* function depend on function which are part of the common interface.

Comment 7

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8653990 [details] [diff] [review]
Use generic memory access operations in header

Review of attachment 8653990 [details] [diff] [review]:
-----------------------------------------------------------------

idem, except that you will have to move these functions to the  mips32/MacroAssembler-mips32-inl.h  and flag them as inlined.

Comment 8

[hev [:hev]]

(In reply to Nicolas B. Pierron [:nbp] from comment #5)
> Comment on attachment 8653916 [details] [diff] [review]
> Merge MacroAssemblerMIPSCompat into MacroAssemblerMIPS
> 
> Review of attachment 8653916 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Sorry, I will remove this review flag, as the MacroAssembler*Compat classes
> are going away and the following patch merge the two classes to rely on the
> generic part of the MacroAssembler (see Bug 996602).
> I'll suggest you to add the asMasm instead of merging the classes.

OK