1199860 - Favicon table init race

Status: RESOLVED FIXED

(Firefox for iOS :: Data Storage, defect)

Description

[Richard Newman [:rnewman]]

2015-08-28 17:40:40.584 [Info] > XCGLogger writing to log to: file:///Users/rnewman/Library/Developer/CoreSimulator/Devices/EA2A2C2B-4814-40D1-92EA-242BDF675BF0/data/Containers/Data/Application/7C863D35-6A3D-4932-8EA6-3803A71C3423/Library/Caches/Logs/sync.20150828T174040-0700.log
2015-08-28 17:40:40.585 [Info] [RollingFileLogger.swift:51] newLogWithDate > Created file destination for logger with root: sync and timestamp: 2015-08-29 00:40:40 +0000
[DEBUG] Did open IPv4 listening socket 7
[DEBUG] Did open IPv6 listening socket 8
[INFO] GCDWebServer started on port 56002 and reachable at http://localhost:56002/
2015-08-28 17:40:40.888 [Info] > XCGLogger writing to log to: file:///Users/rnewman/Library/Developer/CoreSimulator/Devices/EA2A2C2B-4814-40D1-92EA-242BDF675BF0/data/Containers/Data/Application/7C863D35-6A3D-4932-8EA6-3803A71C3423/Library/Caches/Logs/browser.log
2015-08-28 17:40:40.888 [Debug] [BrowserViewController.swift:265] loadQueuedTabs() > Loading queued tabs in the background.
2015-08-28 17:40:40.893 [Debug] [BrowserDB.swift:37] init(filename:secretKey:files:) > Initializing BrowserDB.
2015-08-28 17:40:40.894 [Debug] [BrowserDB.swift:106] createOrUpdate > Create or update tableList version 1.
2015-08-28 17:40:40.898 [Debug] [BrowserDB.swift:56] createTable(_:table:) > Try create tableList version 1
2015-08-28 17:40:40.900 [Debug] [SwiftData.swift:126] transaction > Op in transaction succeeded. Committing.
2015-08-28 17:40:40.903 [Info] [BrowserTable.swift:72] init(version:) > SQLite version: 3.8.8.3 (3008008).
2015-08-28 17:40:40.903 [Debug] [BrowserDB.swift:106] createOrUpdate > Create or update BROWSER version 7.
2015-08-28 17:40:40.908 [Debug] [BrowserDB.swift:348] tablesExist > 0 tables exist. Expected 6
2015-08-28 17:40:40.908 [Debug] [BrowserDB.swift:56] createTable(_:table:) > Try create BROWSER version 7
2015-08-28 17:40:40.909 [Debug] [BrowserTable.swift:266] create(_:version:) > Creating 11 tables, views, and indices.
2015-08-28 17:40:40.911 [Error] [SwiftData.swift:397] executeChange(_:withArgs:) > SQL error: SQL error or missing database no such table: main.favicons for SQL CREATE VIEW IF NOT EXISTS view_favicons_widest AS SELECT favicon_sites.siteID AS siteID, favicons.id AS iconID, favicons.url AS iconURL, favicons.date AS iconDate, favicons.type AS iconType, MAX(favicons.width) AS iconWidth FROM favicon_sites, favicons WHERE favicon_sites.faviconID = favicons.id GROUP BY siteID .
2015-08-28 17:40:40.912 [Error] [BrowserTable.swift:78] run(_:sql:args:) > Error running SQL in BrowserTable. Optional("SQL error or missing database no such table: main.favicons")
2015-08-28 17:40:40.915 [Error] [BrowserTable.swift:79] run(_:sql:args:) > SQL was CREATE VIEW IF NOT EXISTS view_favicons_widest AS SELECT favicon_sites.siteID AS siteID, favicons.id AS iconID, favicons.url AS iconURL, favicons.date AS iconDate, favicons.type AS iconType, MAX(favicons.width) AS iconWidth FROM favicon_sites, favicons WHERE favicon_sites.faviconID = favicons.id GROUP BY siteID 
2015-08-28 17:40:40.915 [Debug] [BrowserDB.swift:59] createTable(_:table:) > Creation failed.
2015-08-28 17:40:40.916 [Debug] [SwiftData.swift:133] transaction > Op in transaction failed. Rolling back.
2015-08-28 17:40:40.917 [Debug] [BrowserDB.swift:159] createOrUpdate > Couldn't create or update BROWSER.
2015-08-28 17:40:40.920 [Debug] [BrowserDB.swift:160] createOrUpdate > Attempting to move browser.db to another location.
2015-08-28 17:40:40.923 [Debug] [BrowserDB.swift:56] createTable(_:table:) > Try create BROWSER version 7
2015-08-28 17:40:40.923 [Debug] [BrowserTable.swift:266] create(_:version:) > Creating 11 tables, views, and indices.
2015-08-28 17:40:40.926 [Error] [SwiftData.swift:397] executeChange(_:withArgs:) > SQL error: SQL error or missing database no such table: main.favicons for SQL CREATE VIEW IF NOT EXISTS view_favicons_widest AS SELECT favicon_sites.siteID AS siteID, favicons.id AS iconID, favicons.url AS iconURL, favicons.date AS iconDate, favicons.type AS iconType, MAX(favicons.width) AS iconWidth FROM favicon_sites, favicons WHERE favicon_sites.faviconID = favicons.id GROUP BY siteID .
2015-08-28 17:40:40.926 [Error] [BrowserTable.swift:78] run(_:sql:args:) > Error running SQL in BrowserTable. Optional("SQL error or missing database no such table: main.favicons")
2015-08-28 17:40:40.927 [Error] [BrowserTable.swift:79] run(_:sql:args:) > SQL was CREATE VIEW IF NOT EXISTS view_favicons_widest AS SELECT favicon_sites.siteID AS siteID, favicons.id AS iconID, favicons.url AS iconURL, favicons.date AS iconDate, favicons.type AS iconType, MAX(favicons.width) AS iconWidth FROM favicon_sites, favicons WHERE favicon_sites.faviconID = favicons.id GROUP BY siteID 
2015-08-28 17:40:40.927 [Debug] [BrowserDB.swift:59] createTable(_:table:) > Creation failed.
2015-08-28 17:40:40.928 [Debug] [SwiftData.swift:133] transaction > Op in transaction failed. Rolling back.
2015-08-28 17:40:40.931 [Error] [SwiftData.swift:424] executeQuery(_:factory:withArgs:) > SQL error: SQL error or missing database no such table: queue.
2015-08-28 17:40:40.932 [Debug] [DeferredDBOperation.swift:90] main() > Modified rows: 0.
2015-08-28 17:40:40.934 [Debug] [BrowserViewController.swift:279] dequeueQueuedTabs() > Queue. Count: 0.
2015-08-28 17:40:40.937 [Error] [SwiftData.swift:397] executeChange(_:withArgs:) > SQL error: SQL error or missing database no such table: queue for SQL DELETE FROM queue.
2015-08-28 17:40:40.938 [Debug] [SwiftData.swift:133] transaction > Op in transaction failed. Rolling back.
2015-08-28 17:40:41.189 [Debug] [BrowserDB.swift:106] createOrUpdate > Create or update favicons version 0.
2015-08-28 17:40:41.196 [Debug] [BrowserDB.swift:56] createTable(_:table:) > Try create favicons version 0
2015-08-28 17:40:41.197 [Error] [SwiftData.swift:397] executeChange(_:withArgs:) > SQL error: SQL error or missing database no such table: tableList for SQL INSERT INTO tableList (name, version) VALUES (?,?).
2015-08-28 17:40:41.198 [Debug] [SwiftData.swift:133] transaction > Op in transaction failed. Rolling back.
2015-08-28 17:40:41.198 [Debug] [BrowserDB.swift:159] createOrUpdate > Couldn't create or update favicons.
2015-08-28 17:40:41.198 [Debug] [BrowserDB.swift:160] createOrUpdate > Attempting to move browser.db to another location.
2015-08-28 17:40:41.199 [Debug] [BrowserDB.swift:56] createTable(_:table:) > Try create favicons version 0
2015-08-28 17:40:41.199 [Error] [SwiftData.swift:397] executeChange(_:withArgs:) > SQL error: SQL error or missing database no such table: tableList for SQL INSERT INTO tableList (name, version) VALUES (?,?).
2015-08-28 17:40:41.202 [Debug] [SwiftData.swift:133] transaction > Op in transaction failed. Rolling back.
Client was compiled with optimization - stepping may behave oddly; variables may not be available.
(lldb)

Comment 1

[Richard Newman [:rnewman]]

Attachment: Pull req.

Comment 2

[Richard Newman [:rnewman]]

b44dcec