Closed Bug 1199910 Opened 9 years ago Closed 9 years ago

TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/unit/test_context_menu.js | xpcshell return code: 0

Categories

(Toolkit :: Password Manager, defect)

Product:
Toolkit
Component:
Password Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla43
Tracking Flags:
Tracking Status
firefox43 --- fixed

People

(Reporter: aleth, Assigned: aleth)

References

Details

Attachments

(1 file)

logincontext.diff
1.27 KB, patch
MattN
: review+
Details | Diff | Splinter Review 
      No description provided.
This is a NS_ERROR_FILE_NOT_FOUND on Cu.import("resource://gre/modules/LoginManagerContextMenu.jsm");
It's not finding the file as it's browser-specific, cf. https://dxr.mozilla.org/comm-central/source/mozilla/toolkit/components/passwordmgr/moz.build?offset=600#71.

Looks like test_context_menu.js should be skipped if CONFIG['MOZ_BUILD_APP'] != 'browser'.
Blocks: 433238
Flags: needinfo?(bernardo)
I guess what's needed is a 
run-if = appname == "browser"
in the ini file.
(In reply to aleth [:aleth] from comment #3)
> I guess what's needed is a 
> run-if = appname == "browser"
> in the ini file.

Sorry, buildapp, not appname, of course.
Feel free to submit a patch and I can review it.
If this is a browser-only test, maybe it would make sense to move the whole test to /browser?

        Attachment #8654835 -
        Flags: review?(MattN+bmo)

    
  
Component: General → Password Manager
Product: Thunderbird → Toolkit

    
    

    
  
Comment on attachment 8654835 [details] [diff] [review]
logincontext.diff

Review of attachment 8654835 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks

        Attachment #8654835 -
        Flags: review?(MattN+bmo) → review+

    
    

    
  
Thank you for the patch, aleth.
Flags: needinfo?(bernardo)

    
  
Keywords: intermittent-failure → checkin-needed
Assignee: nobody → aleth
Status: NEW → ASSIGNED

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/72566e54e209
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox43:
          --- → fixed
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla43

    
    

    
      
  

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: