1200187 - Failed to compile nsEdgeReadingListExtractor.cpp: error C2664: cannot convert argument from 'char16_t *' to 'JET_PCWSTR'

Status: RESOLVED FIXED

(Firefox :: Migration, defect)

Description

[Jan Henning [:JanH]]

Trying to build Firefox on Windows 7 and VS2015 with "--enable-debug --disable-optimize" fails with this error:

> 23:40.36 nsEdgeReadingListExtractor.cpp
> 23:40.36 d:/mozilla-source/mozilla-central/browser/components/migration/nsEdgeReadingListExtractor.cpp(57): error C2664: "JET_ERR JetGetDatabaseFileInfoW(JET_PCWSTR,void *,unsigned long,unsigned long)" : Konvertierung von Argument 1 von "char16_t *" in "JET_PCWSTR" nicht möglich
> 23:40.36 d:/mozilla-source/mozilla-central/browser/components/migration/nsEdgeReadingListExtractor.cpp(57): note: Die Typen, auf die verwiesen wird, sind nicht verknüpft; die Konvertierung erfordert einen reinterpret_cast-Operator oder eine Typumwandlung im C- oder Funktionsformat.
> 23:40.36 d:/mozilla-source/mozilla-central/browser/components/migration/nsEdgeReadingListExtractor.cpp(80): error C2664: "JET_ERR JetAttachDatabaseW(JET_SESID,JET_PCWSTR,JET_GRBIT)" : Konvertierung von Argument 2 von "char16_t *" in "JET_PCWSTR" nicht möglich
> 23:40.36 d:/mozilla-source/mozilla-central/browser/components/migration/nsEdgeReadingListExtractor.cpp(80): note: Die Typen, auf die verwiesen wird, sind nicht verknüpft; die Konvertierung erfordert einen reinterpret_cast-Operator oder eine Typumwandlung im C- oder Funktionsformat.
> 23:40.36 d:/mozilla-source/mozilla-central/browser/components/migration/nsEdgeReadingListExtractor.cpp(83): error C2664: "JET_ERR JetOpenDatabaseW(JET_SESID,JET_PCWSTR,JET_PCWSTR,JET_DBID *,JET_GRBIT)" : Konvertierung von Argument 2 von "char16_t *" in "JET_PCWSTR" nicht möglich
> 23:40.36 d:/mozilla-source/mozilla-central/browser/components/migration/nsEdgeReadingListExtractor.cpp(83): note: Die Typen, auf die verwiesen wird, sind nicht verknüpft; die Konvertierung erfordert einen reinterpret_cast-Operator oder eine Typumwandlung im C- oder Funktionsformat.

Two days ago, before the patch for bug 1193387 was merged into mozilla-central, I was able to build successfully.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

Change line 53 from
> char16_t* dbPath = ToNewUnicode(aDBPath);
to
> char16ptr_t dbPath = ToNewUnicode(aDBPath);
should fix this issue.

Comment 2

[Jan Henning [:JanH]]

Yes, build ran successfully with that change, thanks.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 8654902 [details] [diff] [review]
Patch

Review of attachment 8654902 [details] [diff] [review]:
-----------------------------------------------------------------

Aren't you leaking this string? ToNewUnicode calls NS_StringCloneData which allocated a new buffer, but I don't see where that gets freed in this code. The buffer should land in something that frees it when it falls out of scope.

Comment 5

[Xidorn Quan [:xidorn] UTC+11]

(In reply to Jim Mathies [:jimm] from comment #4)
> Aren't you leaking this string? ToNewUnicode calls NS_StringCloneData which
> allocated a new buffer, but I don't see where that gets freed in this code.
> The buffer should land in something that frees it when it falls out of scope.

Isn't that a bug from bug 1193387? I don't think that should be a blocker for this bug...

Comment 6

[Jim Mathies [:jimm]]

Comment on attachment 8654902 [details] [diff] [review]
Patch

Yeah you're right, I was just being lazy. Filed bug 1200656.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/395305136abd

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/395305136abd