1200420 - MarionetteBaseTestRunner defaults startup_timeout to None, should be seconds

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Eric Rahm [:erahm]]

MarionetteBaseTestRunner defaults startup_timeout to 'None', this cascades down [1] and overrides the default transport timeout in the Marionette class of '60' [2] which causes an exception:

> Traceback (most recent call last):
>   File "/home/erahm/dev/areweslimyet/benchtester/MarionetteTest.py", line 111, in run_test
>     runner.run_tests([ testpath ])
>   File "/home/erahm/dev/areweslimyet/marionette-env/local/lib/python2.7/site-packages/marionette/runner/base.py", line 724, in run_tests
>     self.start_marionette()
>   File "/home/erahm/dev/areweslimyet/marionette-env/local/lib/python2.7/site-packages/marionette/runner/base.py", line 669, in start_marionette
>     self.marionette = self.driverclass(**self._build_kwargs())
>   File "/home/erahm/dev/areweslimyet/marionette-env/local/lib/python2.7/site-packages/marionette_driver/marionette.py", line 591, in __init__
>     assert(self.wait_for_port(timeout=startup_timeout)), "Timed out waiting for port!"
>   File "/home/erahm/dev/areweslimyet/marionette-env/local/lib/python2.7/site-packages/marionette_driver/marionette.py", line 667, in wait_for_port
>     timeout=timeout)
>   File "/home/erahm/dev/areweslimyet/marionette-env/local/lib/python2.7/site-packages/marionette_transport/transport.py", line 122, in wait_for_port
>     while datetime.datetime.now() - starttime < datetime.timedelta(seconds=timeout):
> TypeError: unsupported type for timedelta seconds component: NoneType

[1] https://dxr.mozilla.org/mozilla-central/rev/f2518b8a7b97b5bb477e94bc9131584007aac887/testing/marionette/client/marionette/runner/base.py#474,520,620
[2] https://dxr.mozilla.org/mozilla-central/rev/f2518b8a7b97b5bb477e94bc9131584007aac887/testing/marionette/driver/marionette_driver/marionette.py#540,591

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: MozReview Request: Bug 1200420 - Better handling of startup_timeout, r=AutomatedTester

Bug 1200420 - Better handling of startup_timeout, r=AutomatedTester

Comment 2

[Jonathan Griffin (:jgriffin)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2dd1bdf41c63

Comment 3

[David Burns :automatedtester]

Comment on attachment 8655092 [details]
MozReview Request: Bug 1200420 - Better handling of startup_timeout, r=AutomatedTester

https://reviewboard.mozilla.org/r/17819/#review16303

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f899c037047e

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f899c037047e