1201370 - Remote cppunit test is unable to launch x86 emulator correctly

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Edgar Chen [:edgar]]

remotecppunittests doesn't tell mozrunner which kind of arch should be launch, so mozrunner use the default one [2]. We have to find some way to pass the arch information to remotecppunuttests.

[1] https://dxr.mozilla.org/mozilla-central/source/testing/remotecppunittests.py?offset=0#230
[2] https://dxr.mozilla.org/mozilla-central/source/testing/mozbase/mozrunner/mozrunner/runners.py?offset=0#87

Comment 1

[John Dai[:jdai]]

Add try link:
https://treeherder.allizom.org/#/jobs?repo=try&revision=59750d419805

Comment 2

[John Dai[:jdai]]

Attachment: WIP, patch, v1

try looks good:
https://treeherder.allizom.org/#/jobs?repo=try&revision=8ffd6d645a91

Comment 3

[John Dai[:jdai]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1351a518e72

Comment 4

[John Dai[:jdai]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4dde9544a242

Comment 5

[John Dai[:jdai]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5ad7dd9af6e

Comment 6

[John Dai[:jdai]]

Attachment: MozReview Request: Bug 1201370 - Add emulator parameter to cppunit test. r=ahal

Bug 1201370 - Add emulator architecture parameter to cppunit test; r?ahal

Comment 7

[John Dai[:jdai]]

Since I can't retrigger failed test, I put 2 try link for you to reference.

Try link:
With x86-kk try error but others are green:
https://treeherder.allizom.org/#/jobs?repo=try&revision=f825cdfbfc3e
Without x86-kk try error:
https://treeherder.allizom.org/#/jobs?repo=try&revision=0b018ffcf7e6

Comment 8

[Andrew Halberstadt [:ahal]]

Comment on attachment 8664621 [details]
MozReview Request: Bug 1201370 - Add emulator parameter to cppunit test. r=ahal

https://reviewboard.mozilla.org/r/20017/#review18071

::: testing/remotecppunittests.py:230
(Diff revision 1)
> -
> +        self.add_option("--emulator", action="store",
> +                    type="string", dest = "emulator",

nit: the action, type and dest parameters aren't needed here as those are already the default values.

::: testing/remotecppunittests.py:232
(Diff revision 1)
> +                    help = "Architecture of emulator to use: x86 or arm")

You should add a 'choices' parameter, that way it'll fail fast if someone types something other than 'arm' or 'x86':
https://docs.python.org/2.7/library/argparse.html#choices

Comment 9

[John Dai[:jdai]]

Comment on attachment 8664621 [details]
MozReview Request: Bug 1201370 - Add emulator parameter to cppunit test. r=ahal

Bug 1201370 - Add emulator parameter to cppunit test; r?ahal

Comment 10

[John Dai[:jdai]]

Try link:
https://treeherder.allizom.org/#/jobs?repo=try&revision=2415e8e93ae5

Comment 11

[Andrew Halberstadt [:ahal]]

Comment on attachment 8664621 [details]
MozReview Request: Bug 1201370 - Add emulator parameter to cppunit test. r=ahal

https://reviewboard.mozilla.org/r/20017/#review18195

Thanks!

Comment 12

[John Dai[:jdai]]

Comment on attachment 8664621 [details]
MozReview Request: Bug 1201370 - Add emulator parameter to cppunit test. r=ahal

Bug 1201370 - Add emulator parameter to cppunit test. r=ahal

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6e77b81bc2a7

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6e77b81bc2a7